Re: [dpdk-dev] [PATCH v4 2/2] ring: move the atomic load of head above the loop

2018-11-02 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Thomas Monjalon > Sent: Friday, November 2, 2018 5:37 PM > To: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli > Cc: Stephen Hemminger ; dev@dpdk.org; > olivier.m...@6wind.com; chao...@linux.vnet.ibm.com; > bruce.richard...@intel.com; konstantin.an

Re: [dpdk-dev] [PATCH v4 2/2] ring: move the atomic load of head above the loop

2018-11-02 Thread Thomas Monjalon
02/11/2018 08:15, Gavin Hu (Arm Technology China): > > > -Original Message- > > From: Honnappa Nagarahalli > > Sent: Friday, November 2, 2018 12:31 PM > > To: Gavin Hu (Arm Technology China) ; Stephen > > Hemminger > > Cc: dev@dpdk.org; tho...@monjalon.net; olivier.m...@6wind.com; > > cha

Re: [dpdk-dev] [PATCH v4 2/2] ring: move the atomic load of head above the loop

2018-11-02 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, November 2, 2018 12:31 PM > To: Gavin Hu (Arm Technology China) ; Stephen > Hemminger > Cc: dev@dpdk.org; tho...@monjalon.net; olivier.m...@6wind.com; > chao...@linux.vnet.ibm.com; bruce.richard...@intel.com; > konstantin

Re: [dpdk-dev] [PATCH v4 2/2] ring: move the atomic load of head above the loop

2018-11-01 Thread Honnappa Nagarahalli
  On Thu, 1 Nov 2018 17:53:51 +0800 Gavin Hu wrote: > +* **Updated the ring library with C11 memory model.** > + > + Updated the ring library with C11 memory model including the following > changes: > + > + * Synchronize the load and store of the tail > + * Move

Re: [dpdk-dev] [PATCH v4 2/2] ring: move the atomic load of head above the loop

2018-11-01 Thread Gavin Hu (Arm Technology China)
Hi Stephen, There is no api changes, but this is a significant change as ring is fundamental and widely used, it decreases latency by 25% in our tests, it may do even better for cases with more contending producers/consumers or deeper depth of rings. Best regards Gavin Best regards Gavin ___

Re: [dpdk-dev] [PATCH v4 2/2] ring: move the atomic load of head above the loop

2018-11-01 Thread Stephen Hemminger
On Thu, 1 Nov 2018 17:53:51 +0800 Gavin Hu wrote: > +* **Updated the ring library with C11 memory model.** > + > + Updated the ring library with C11 memory model including the following > changes: > + > + * Synchronize the load and store of the tail > + * Move the atomic load of head above t