Re: [dpdk-dev] [PATCH v4 02/15] ethdev: add support for hairpin queue

2019-10-23 Thread Bruce Richardson
gt; > ; jingjing...@intel.com; > > step...@networkplumber.org > > Subject: Re: [dpdk-dev] [PATCH v4 02/15] ethdev: add support for hairpin > > queue > > > > 17/10/2019 17:32, Ori Kam: > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev

Re: [dpdk-dev] [PATCH v4 02/15] ethdev: add support for hairpin queue

2019-10-23 Thread Ori Kam
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 23, 2019 10:05 AM > To: Ori Kam > Cc: dev@dpdk.org; Ferruh Yigit ; Andrew Rybchenko > ; jingjing...@intel.com; > step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v4 02

Re: [dpdk-dev] [PATCH v4 02/15] ethdev: add support for hairpin queue

2019-10-23 Thread Thomas Monjalon
17/10/2019 17:32, Ori Kam: > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > /** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * A structure used to return the hairpin capabilities that are supported. > + */ >

Re: [dpdk-dev] [PATCH v4 02/15] ethdev: add support for hairpin queue

2019-10-22 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 22, 2019 2:38 PM > To: Ori Kam ; Thomas Monjalon > ; Ferruh Yigit > Cc: dev@dpdk.org; jingjing...@intel.com; step...@networkplumber.org > Subject: Re: [PATCH v4 02/15] ethdev: add support for hairpin queue

Re: [dpdk-dev] [PATCH v4 02/15] ethdev: add support for hairpin queue

2019-10-22 Thread Andrew Rybchenko
Hi Ori, see my notes below. A generic note is that we have strict policy about Rx/Tx (not RX/TX) in commit messages, but I'd like to follow it in comments and log messages at least in a new code. It is already a mixture in the existing code. On 10/17/19 6:32 PM, Ori Kam wrote: This commit intr

Re: [dpdk-dev] [PATCH v4 02/15] ethdev: add support for hairpin queue

2019-10-17 Thread Thomas Monjalon
17/10/2019 17:32, Ori Kam: > V4: > - update according to ML comments. > > V3: > - update according to ML comments. > > V2: > - update according to ML comments. I would prefer to see a summary of the changes in the changelog, so we can easily track the progress.