On Wed, Oct 23, 2019 at 10:09:45AM +0000, Ori Kam wrote:
> Hi Thomas,
>
> > -----Original Message-----
> > From: Thomas Monjalon <tho...@monjalon.net>
> > Sent: Wednesday, October 23, 2019 10:05 AM
> > To: Ori Kam <or...@mellanox.com>
> > Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yi...@intel.com>; Andrew Rybchenko
> > <arybche...@solarflare.com>; jingjing...@intel.com;
> > step...@networkplumber.org
> > Subject: Re: [dpdk-dev] [PATCH v4 02/15] ethdev: add support for hairpin
> > queue
> >
> > 17/10/2019 17:32, Ori Kam:
> > > --- a/lib/librte_ethdev/rte_ethdev.h
> > > +++ b/lib/librte_ethdev/rte_ethdev.h
> > > /**
> > > + * @warning
> > > + * @b EXPERIMENTAL: this API may change, or be removed, without prior
> > notice
> > > + *
> > > + * A structure used to return the hairpin capabilities that are
> > > supported.
> > > + */
> > > +struct rte_eth_hairpin_cap {
> > > + uint16_t max_n_queues;
> > > + /**< The max number of hairpin queues (different bindings). */
> > > + uint16_t max_rx_2_tx;
> > > + /**< Max number of Rx queues to be connected to one Tx queue. */
> > > + uint16_t max_tx_2_rx;
> > > + /**< Max number of Tx queues to be connected to one Rx queue. */
> > > + uint16_t max_nb_desc; /**< The max num of descriptors. */
> > > +};
> >
> > I think you can switch to "comment-first style" for this struct.
> >
>
> O.K I will change.
>
> >
> > > +#define RTE_ETH_MAX_HAIRPIN_PEERS 32
> >
> > Usually I think such define is in the build config.
> > Any other opinion?
> >
+1 for not moving it to the build config unless absolutely necessary.
