Re: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows

2021-04-14 Thread Jie Zhou
On Wed, Apr 14, 2021 at 08:45:31PM +0300, Dmitry Kozlyuk wrote: > 2021-04-14 10:16 (UTC-0700), Jie Zhou: > > On Tue, Apr 13, 2021 at 03:22:57PM -0700, Jie Zhou wrote: > > > On Tue, Apr 13, 2021 at 11:10:00PM +0300, Dmitry Kozlyuk wrote: > > > > 2021-04-13 10:19 (UTC-0700), Jie Zhou: > > > > [...]

Re: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows

2021-04-14 Thread Dmitry Kozlyuk
2021-04-14 10:16 (UTC-0700), Jie Zhou: > On Tue, Apr 13, 2021 at 03:22:57PM -0700, Jie Zhou wrote: > > On Tue, Apr 13, 2021 at 11:10:00PM +0300, Dmitry Kozlyuk wrote: > > > 2021-04-13 10:19 (UTC-0700), Jie Zhou: > > > [...] > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline

Re: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows

2021-04-14 Thread Jie Zhou
On Tue, Apr 13, 2021 at 03:22:57PM -0700, Jie Zhou wrote: > On Tue, Apr 13, 2021 at 11:10:00PM +0300, Dmitry Kozlyuk wrote: > > 2021-04-13 10:19 (UTC-0700), Jie Zhou: > > [...] > > > diff --git a/app/meson.build b/app/meson.build > > > index 50a53dbde..b40b04ca7 100644 > > > --- a/app/meson.build >

Re: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows

2021-04-13 Thread Jie Zhou
On Tue, Apr 13, 2021 at 11:10:00PM +0300, Dmitry Kozlyuk wrote: > 2021-04-13 10:19 (UTC-0700), Jie Zhou: > [...] > > diff --git a/app/meson.build b/app/meson.build > > index 50a53dbde..b40b04ca7 100644 > > --- a/app/meson.build > > +++ b/app/meson.build > > @@ -1,10 +1,6 @@ > > # SPDX-License-Iden

Re: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows

2021-04-13 Thread Jie Zhou
On Tue, Apr 13, 2021 at 06:58:16PM +, Tal Shnaiderman wrote: > > Subject: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on > > Windows > > > > External email: Use caution opening links or attachments > > > > > > From: Jie Zhou > > > > I think this patch can be split further since

Re: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows

2021-04-13 Thread Dmitry Kozlyuk
2021-04-13 10:19 (UTC-0700), Jie Zhou: [...] > diff --git a/app/meson.build b/app/meson.build > index 50a53dbde..b40b04ca7 100644 > --- a/app/meson.build > +++ b/app/meson.build > @@ -1,10 +1,6 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017-2019 Intel Corporation > > -if is_

Re: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows

2021-04-13 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on > Windows > > External email: Use caution opening links or attachments > > > From: Jie Zhou > I think this patch can be split further since it contains different topics, I would've split it at least to the following: 1) Res