On Wed, Apr 14, 2021 at 08:45:31PM +0300, Dmitry Kozlyuk wrote:
> 2021-04-14 10:16 (UTC-0700), Jie Zhou:
> > On Tue, Apr 13, 2021 at 03:22:57PM -0700, Jie Zhou wrote:
> > > On Tue, Apr 13, 2021 at 11:10:00PM +0300, Dmitry Kozlyuk wrote:
> > > > 2021-04-13 10:19 (UTC-0700), Jie Zhou:
> > > > [...]
> > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> > > > > index fb7a3a8bd..9945adcf1 100644
> > > > > --- a/app/test-pmd/cmdline_flow.c
> > > > > +++ b/app/test-pmd/cmdline_flow.c
> > > > > @@ -31,6 +31,12 @@
> > > > >
> > > > > #include "testpmd.h"
> > > > >
> > > > > +#ifdef RTE_EXEC_ENV_WINDOWS
> > > > > +#ifndef IPDEFTTL
> > > > > +#define IPDEFTTL 64
> > > > > +#endif
> > > > > +#endif
> > > > > +
> > > > > /** Parser token indices. */
> > > > > enum index {
> > > > > /* Special tokens. */
> > > >
> > > > IPDEFTTL is used in some other apps and examples.
> > > > If you follow Tal's advice and base your work on "Do not expose POSIX
> > > > symbols" series, then please move this to <rte_os_shim.h>.
> > >
> > > I applied "eal/windows:do not expose POSIX symbols" per your and Tal's
> > > advices, but hit error LNK2019: unresolved external symbol strdup
> > > reference in function log_save_level". I am using clang version 10.0.0.
> >
> > [Update] Seems the problem is at applying the patch series, even though it
> > showed all sucessfully applied, but somehow in eal_common_log.c the include
> > of <rte_os_shim.h> was not added. After add include rte_os_shim.h, build
> > completes.
>
> Are you applying v9? It includes this exact fix.
Thanks. Applied V8 by mistake which has no this change. Now has no issue.
