Re: [dpdk-dev] [PATCH v3 08/16] net/avp: device initialization

2017-03-09 Thread Legacy, Allain
> -Original Message- > From: Legacy, Allain > > From: Chas Williams [mailto:3ch...@gmail.com] > > I don't see the other side of this to unregister the callback. It's also a > > bit > > confusing with this here and the other parts in part 15. It looks like you > > enable the interrupts on

Re: [dpdk-dev] [PATCH v3 08/16] net/avp: device initialization

2017-03-09 Thread Legacy, Allain
> -Original Message- > From: Chas Williams [mailto:3ch...@gmail.com] > I don't see the other side of this to unregister the callback. It's also a > bit > confusing with this here and the other parts in part 15. It looks like you > enable the interrupts on .dev_create but disable on .dev_

Re: [dpdk-dev] [PATCH v3 08/16] net/avp: device initialization

2017-03-03 Thread Chas Williams
On Wed, 2017-03-01 at 19:20 -0500, Allain Legacy wrote: > + /* Check current migration status */ > + if (avp_dev_migration_pending(eth_dev)) { > + PMD_DRV_LOG(ERR, "VM live migration operation in progress\n"); > + return -EBUSY; > + } > + > + /* Check BAR res