Re: [dpdk-dev] [PATCH v2 2/2] ip_frag: use key length for key comparision

2018-11-06 Thread Ananyev, Konstantin
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, November 6, 2018 10:54 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: sta...@dpdk.org; Hall, Ryan E ; Gutkin, Alexander > V > Subject: Re: [dpdk-dev] [PATCH v2 2/2] ip_frag: use key length for key

Re: [dpdk-dev] [PATCH v2 2/2] ip_frag: use key length for key comparision

2018-11-06 Thread Burakov, Anatoly
On 05-Nov-18 12:18 PM, Konstantin Ananyev wrote: Right now reassembly code relies on src_dst[] being all zeroes to determine is it free/occupied entry in the fragments table. This is suboptimal and error prone - user can crash DPDK ip_reassembly app by something like the following scapy script: