Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export

2020-10-16 Thread Thomas Monjalon
16/10/2020 17:48, Kinsella, Ray: > On 16/10/2020 12:22, David Marchand wrote: > > On Fri, Oct 16, 2020 at 1:16 PM Kinsella, Ray wrote: > >> > >> The windows exports and the map files, feels like duplication of effort. > >> Could we massage one into the other during the build? > > > > That's what

Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export

2020-10-16 Thread Bruce Richardson
On Fri, Oct 16, 2020 at 04:48:59PM +0100, Kinsella, Ray wrote: > > On 16/10/2020 12:22, David Marchand wrote: > > On Fri, Oct 16, 2020 at 1:16 PM Kinsella, Ray wrote: > >> > >> > >> The windows exports and the map files, feels like duplication of effort. > >> Could we massage one into the other d

Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export

2020-10-16 Thread Kinsella, Ray
On 16/10/2020 12:22, David Marchand wrote: > On Fri, Oct 16, 2020 at 1:16 PM Kinsella, Ray wrote: >> >> >> The windows exports and the map files, feels like duplication of effort. >> Could we massage one into the other during the build? > > That's what is done with map-to-win.py, unless we have

Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export

2020-10-16 Thread Kinsella, Ray
ah ... perfect. Ray K On 16/10/2020 12:22, David Marchand wrote: > On Fri, Oct 16, 2020 at 1:16 PM Kinsella, Ray wrote: >> >> >> The windows exports and the map files, feels like duplication of effort. >> Could we massage one into the other during the build? > > That's what is done with map-to-

Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export

2020-10-16 Thread David Marchand
On Fri, Oct 16, 2020 at 1:16 PM Kinsella, Ray wrote: > > > The windows exports and the map files, feels like duplication of effort. > Could we massage one into the other during the build? That's what is done with map-to-win.py, unless we have one exception when the full library is not ready, like

Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export

2020-10-16 Thread Kinsella, Ray
The windows exports and the map files, feels like duplication of effort. Could we massage one into the other during the build? On 16/10/2020 11:27, David Marchand wrote: > The incriminated commit forgot to clean the Windows export file. > > Fixes: 3cd73a1a1c4d ("eal: simplify exit functions")