On Fri, Oct 16, 2020 at 04:48:59PM +0100, Kinsella, Ray wrote: > > On 16/10/2020 12:22, David Marchand wrote: > > On Fri, Oct 16, 2020 at 1:16 PM Kinsella, Ray <m...@ashroe.eu> wrote: > >> > >> > >> The windows exports and the map files, feels like duplication of effort. > >> Could we massage one into the other during the build? > > > > That's what is done with map-to-win.py, unless we have one exception > > when the full library is not ready, like EAL. > > > > https://git.dpdk.org/dpdk/tree/lib/meson.build#n152 > > https://git.dpdk.org/dpdk/tree/buildtools/map_to_win.py#n27 > > > > Thinking about this again - future work might be to check if a .def exists. > And then to warn in checkpatch if one is modified without the other? > Possibly, but right now there is only the one .def override file, for EAL, and a better use of effort is to close the gap between windows and other versions so that it can be removed completely.
$ find lib/ drivers/ -name *.def lib/librte_eal/rte_eal_exports.def /Bruce
