Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-24 Thread Olivier Matz
On Thu, Oct 24, 2019 at 07:38:15AM +, Slava Ovsiienko wrote: > Hi, > > Doc building failed, it seems the rte_mbuf_dynfield_copy() description should > be fixed: > > ./lib/librte_mbuf/rte_mbuf.h:1694: warning: argument 'm_dst' of command > @param is not found in the argument list of rte_mbuf

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-24 Thread Slava Ovsiienko
Hi, Doc building failed, it seems the rte_mbuf_dynfield_copy() description should be fixed: ./lib/librte_mbuf/rte_mbuf.h:1694: warning: argument 'm_dst' of command @param is not found in the argument list of rte_mbuf_dynfield_copy(struct rte_mbuf *mdst, const struct rte_mbuf *msrc) ./lib/librt

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-24 Thread Olivier Matz
Hi, On Thu, Oct 24, 2019 at 04:54:20AM +, Shahaf Shuler wrote: > Wednesday, October 23, 2019 4:34 PM, Olivier Matz: > > Subject: Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags > > > > Hi Shahaf, > > > > On Wed, Oct 23, 2019 at 12:0

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Shahaf Shuler
Wednesday, October 23, 2019 4:34 PM, Olivier Matz: > Subject: Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags > > Hi Shahaf, > > On Wed, Oct 23, 2019 at 12:00:30PM +, Shahaf Shuler wrote: > > Hi Olivier, > > > > Thursday, October 17, 2019 5:4

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Wang, Haiyue
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, October 23, 2019 23:00 > To: Olivier Matz > Cc: Wang, Haiyue ; Ananyev, Konstantin > ; > dev@dpdk.org; Andrew Rybchenko ; Richardson, Bruce > ; Jerin Jacob Kollanukkaran ; > Wiles, Keith

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Stephen Hemminger
On Wed, 23 Oct 2019 12:21:43 +0200 Olivier Matz wrote: > On Wed, Oct 23, 2019 at 03:16:13AM +, Wang, Haiyue wrote: > > > -Original Message- > > > From: Ananyev, Konstantin > > > Sent: Wednesday, October 23, 2019 06:52 > > > To: Olivier Matz ; dev@dpdk.org > > > Cc: Andrew Rybchenko ;

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Olivier Matz
Hi Shahaf, On Wed, Oct 23, 2019 at 12:00:30PM +, Shahaf Shuler wrote: > Hi Olivier, > > Thursday, October 17, 2019 5:42 PM, Olivier Matz: > > Subject: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags > > > > Many features require to store data inside the mbuf. As the room in mbu

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Shahaf Shuler
Hi Olivier, Thursday, October 17, 2019 5:42 PM, Olivier Matz: > Subject: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags > > Many features require to store data inside the mbuf. As the room in mbuf > structure is limited, it is not possible to have a field for each feature. > Also,

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Ananyev, Konstantin
> -Original Message- > From: Olivier Matz > Sent: Wednesday, October 23, 2019 12:46 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Andrew Rybchenko ; Richardson, > Bruce ; Wang, > Haiyue ; Jerin Jacob Kollanukkaran > ; Wiles, Keith ; Morten > Brørup ; Stephen Hemminger > ; Thomas

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Olivier Matz
On Wed, Oct 23, 2019 at 12:19:46PM +0200, Olivier Matz wrote: > On Tue, Oct 22, 2019 at 10:51:51PM +, Ananyev, Konstantin wrote: (...) > > > +/* Allocate and initialize the shared memory. Assume tailq is locked */ > > > +static int > > > +init_shared_mem(void) > > > +{ > > > + const struct rt

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Olivier Matz
On Wed, Oct 23, 2019 at 03:16:13AM +, Wang, Haiyue wrote: > > -Original Message- > > From: Ananyev, Konstantin > > Sent: Wednesday, October 23, 2019 06:52 > > To: Olivier Matz ; dev@dpdk.org > > Cc: Andrew Rybchenko ; Richardson, Bruce > > ; Wang, > > Haiyue ; Jerin Jacob Kollanukkaran

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Olivier Matz
On Tue, Oct 22, 2019 at 10:51:51PM +, Ananyev, Konstantin wrote: > > > Many features require to store data inside the mbuf. As the room in mbuf > > structure is limited, it is not possible to have a field for each > > feature. Also, changing fields in the mbuf structure can break the API > > o

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-22 Thread Wang, Haiyue
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, October 23, 2019 06:52 > To: Olivier Matz ; dev@dpdk.org > Cc: Andrew Rybchenko ; Richardson, Bruce > ; Wang, > Haiyue ; Jerin Jacob Kollanukkaran > ; Wiles, Keith > ; Morten Brørup ; Stephen > Hemminger > ; Thomas Monja

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-22 Thread Ananyev, Konstantin
> Many features require to store data inside the mbuf. As the room in mbuf > structure is limited, it is not possible to have a field for each > feature. Also, changing fields in the mbuf structure can break the API > or ABI. > > This commit addresses these issues, by enabling the dynamic regist

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-18 Thread Wang, Haiyue
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, October 18, 2019 17:48 > To: Wang, Haiyue > Cc: dev@dpdk.org; Andrew Rybchenko ; Richardson, > Bruce > ; Jerin Jacob Kollanukkaran ; > Wiles, Keith > ; Ananyev, Konstantin ; > Morten Brørup > ; Ste

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-18 Thread Olivier Matz
On Fri, Oct 18, 2019 at 08:28:02AM +, Wang, Haiyue wrote: > Hi Olivier, > > > -Original Message- > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Friday, October 18, 2019 15:54 > > To: Wang, Haiyue > > Cc: dev@dpdk.org; Andrew Rybchenko ; Richardson, > > Bruce > > ; J

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-18 Thread Wang, Haiyue
Hi Olivier, > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, October 18, 2019 15:54 > To: Wang, Haiyue > Cc: dev@dpdk.org; Andrew Rybchenko ; Richardson, > Bruce > ; Jerin Jacob Kollanukkaran ; > Wiles, Keith > ; Ananyev, Konstantin ; > Morten B

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-18 Thread Olivier Matz
Hi Haiyue, On Fri, Oct 18, 2019 at 02:47:50AM +, Wang, Haiyue wrote: > Hi Olivier > > > -Original Message- > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Thursday, October 17, 2019 22:42 > > To: dev@dpdk.org > > Cc: Andrew Rybchenko ; Richardson, Bruce > > ; Wang, >

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-17 Thread Wang, Haiyue
Hi Olivier > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Thursday, October 17, 2019 22:42 > To: dev@dpdk.org > Cc: Andrew Rybchenko ; Richardson, Bruce > ; Wang, > Haiyue ; Jerin Jacob Kollanukkaran > ; Wiles, Keith > ; Ananyev, Konstantin ; > Morten