Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21

2020-04-30 Thread Ray Kinsella
On 29/04/2020 13:19, Dodji Seketeli wrote: > Hello, > > Ray Kinsella writes: > >> ah ok, the particular system I made the change on was Ubuntu 18.04.2. >> which is libabigail 1.2.0. > > Whoah, 1.2 is super old. I have a huge clunking raid'ed "build" server, that I am pretty conservative abo

Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21

2020-04-29 Thread Dodji Seketeli
Hello, Ray Kinsella writes: > ah ok, the particular system I made the change on was Ubuntu 18.04.2. > which is libabigail 1.2.0. Whoah, 1.2 is super old. In my opinion, one of the hallmarks of static analysis tools (and libabigail is just a static analysis framework) is to be able to recognize

Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21

2020-04-24 Thread David Marchand
On Fri, Apr 24, 2020 at 4:50 PM Ray Kinsella wrote: > > ah ok, the particular system I made the change on was Ubuntu 18.04.2. > which is libabigail 1.2.0. > > Given we still support v19.11 on Ubuntu 18.04.2. > I think it's worthwhile keeping the suppression until v20.11? 1.2 is fairly old and doe

Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21

2020-04-24 Thread Ray Kinsella
ah ok, the particular system I made the change on was Ubuntu 18.04.2. which is libabigail 1.2.0. Given we still support v19.11 on Ubuntu 18.04.2. I think it's worthwhile keeping the suppression until v20.11? Ray K On 24/04/2020 15:10, David Marchand wrote: > On Thu, Apr 23, 2020 at 8:48 AM Ray K

Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21

2020-04-24 Thread David Marchand
On Thu, Apr 23, 2020 at 8:48 AM Ray Kinsella wrote: > > Change references to abi 20.0.1 to use abi v21, add myself as the map > file maintainer to more closely monitor future abi changes. Add > suppressions that were missed on changes to librte_lpm. About the lpm change below, this might be becau

Re: [dpdk-dev] [PATCH v2] abi: change references to abi 20.0.1 to abi v21

2020-04-24 Thread Thomas Monjalon
23/04/2020 08:41, Ray Kinsella: > Change references to abi 20.0.1 to use abi v21, add myself as the map > file maintainer to more closely monitor future abi changes. Add > suppressions that were missed on changes to librte_lpm. > > Signed-off-by: Ray Kinsella Please could you add a reference to