Re: [dpdk-dev] [PATCH v1 4/9] app/procinfo: add code for debug port

2018-10-27 Thread Varghese, Vipin
> > > > +char bdr_str[100]; > > #define for marco size would be good. Instead of hard code. Yes, agreed. > > + struct rte_eth_link link = {0}; > > Initialize structs using memset here and in other places. > Will change for v3 > > + printf("\t -- RSS len %u key

Re: [dpdk-dev] [PATCH v1 4/9] app/procinfo: add code for debug port

2018-10-26 Thread Varghese, Vipin
> > + printf("\t -- RSS len %u key (hex):", > > Why "(hex)" in printf? In the follow up lines, we are disapplying the RSS key used in HEX values. for (k = 0; k < rss_conf.rss_key_len; k++) printf(" %x", rss_conf.rss_key[k]);

Re: [dpdk-dev] [PATCH v1 4/9] app/procinfo: add code for debug port

2018-10-25 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Tuesday, October 23, 2018 2:58 PM > + printf("\t -- RSS len %u key (hex):", Why "(hex)" in printf?

Re: [dpdk-dev] [PATCH v1 4/9] app/procinfo: add code for debug port

2018-10-25 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Tuesday, October 23, 2018 2:58 PM > To: dev@dpdk.org; Tahhan, Maryam ; Pattan, > Reshma > Cc: Patel, Amol ; Tummala, Sivaprasad > ; Byrne, Stephen1 > ; Glynn, Michael J > ; Varghese, Vipin > Subject: [PATCH v1 4/9] app/procinfo: add