Re: [dpdk-dev] [PATCH 1/2] bitmap: add create bitmap with all bits set

2020-04-07 Thread Suanming Mou
Hi > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, April 8, 2020 1:48 AM > To: Suanming Mou > Cc: dev@dpdk.org > Subject: RE: [PATCH 1/2] bitmap: add create bitmap with all bits set > > Hi Suanming, > > > -Original Message- > > From: Suanming Mou > > Sent

Re: [dpdk-dev] [PATCH 1/2] bitmap: add create bitmap with all bits set

2020-04-07 Thread Dumitrescu, Cristian
Hi Suanming, > -Original Message- > From: Suanming Mou > Sent: Tuesday, March 10, 2020 8:21 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: [PATCH 1/2] bitmap: add create bitmap with all bits set > > Currently, in the case to use bitmap as resource allocator, after > bitmap

Re: [dpdk-dev] [PATCH 1/2] bitmap: add create bitmap with all bits set

2020-04-07 Thread Suanming Mou
Hi guys, Since we are all quite curious about which is the best implementation for the performance, I just did some test on my server. There will be 3 implementations. 1. Clear all the array1 and array2 bits first, then set the bits we needed.(The current implementation in the patch). 2. Set

Re: [dpdk-dev] [PATCH 1/2] bitmap: add create bitmap with all bits set

2020-04-06 Thread Suanming Mou
On 4/3/2020 10:49 PM, Andrzej Ostruszka wrote: Hello Suanming Please find my comments below. However please note that so far I have never used DPDK bitmaps so I might not be the best person to comment - this patch needs some attention so I spent some time on it. Overall I'm fine with the chang

Re: [dpdk-dev] [PATCH 1/2] bitmap: add create bitmap with all bits set

2020-04-03 Thread Andrzej Ostruszka
Hello Suanming Please find my comments below. However please note that so far I have never used DPDK bitmaps so I might not be the best person to comment - this patch needs some attention so I spent some time on it. Overall I'm fine with the changes however since this is a performance enhancemen