Re: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops"

2018-02-01 Thread Hemant Agrawal
HI Pavan, > Currently, best_mempool_ops is broken because when > rte_mbuf_user_mempool_ops is invoked it is expected to returns 'NULL' through > internal_config.user_mbuf_pool_ops_name. IMO it is best to create a named > memzone ('mbuf_user_pool_ops') at the end of eal_init and copy mbuf-pool

Re: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops"

2018-02-01 Thread Pavan Nikhilesh
Hi Hemanth, Currently, best_mempool_ops is broken because when rte_mbuf_user_mempool_ops is invoked it is expected to returns 'NULL' through internal_config.user_mbuf_pool_ops_name. IMO it is best to create a named memzone ('mbuf_user_pool_ops') at the end of eal_init and copy mbuf-pool-op

Re: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops"

2018-02-01 Thread Hemant Agrawal
Hi Pavan, Your patch was breaking the design of the best_mempool_ops and the whole purpose of selection was getting lost. I guess you were trying to fix test_mempool. I have sent another patch, which fixes that and start using the best mempool ops API instead of default mempool ops API