HI Pavan,
> Currently, best_mempool_ops is broken because when
> rte_mbuf_user_mempool_ops is invoked it is expected to returns 'NULL' through
> internal_config.user_mbuf_pool_ops_name. IMO it is best to create a named
> memzone ('mbuf_user_pool_ops') at the end of eal_init and copy mbuf-pool-ops
> passed to eal.
>
> `rte_eal_mbuf_default_mempool_ops` is not expected to return 'NULL' would
> doing so break the ABI?.
>
> ---
> /**
> * Get default pool ops name for mbuf
> *
> * @return
> * returns default pool ops name.
> */
> const char *
> rte_eal_mbuf_default_mempool_ops(void);
> ---
>
> IMO creating named mempool at the end of eal_init and changing
> `rte_mbuf_user_mempool_ops` as below would be a better solution.
>
> rte_mbuf_user_mempool_ops(void)
> {
> ...
> mz = rte_memzone_lookup("mbuf_user_pool_ops");
> if (mz == NULL)
> return NULL;
> ...
> }
>
> Thoughts?
[Hemant] It seems reasonable. We can also deprecate the eal default mempool
ops API . I will be sending patch shortly.
Unfortunately all NXP platforms are broken at the moment, so we need to get it
fixed fast.
Hemant
>
> Pavan.
>
> On Thu, Feb 01, 2018 at 07:56:47PM +0000, Hemant Agrawal wrote:
> > Hi Pavan,
> > Your patch was breaking the design of the best_mempool_ops and the
> whole purpose of selection was getting lost.
> > I guess you were trying to fix test_mempool. I have sent another
> > patch, which fixes that and start using the best mempool ops API instead of
> default mempool ops API.
> >
> > Regards,
> > Hemant
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal
> > > Sent: Friday, February 02, 2018 1:17 AM
> > > To: olivier.m...@6wind.com; pbhagavat...@caviumnetworks.com
> > > Cc: tho...@monjalon.net; dev@dpdk.org
> > > Subject: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops"
> > >
> > > This reverts commit fe06cb6c54fe5ada299ebba40a382bee37c919f2.
> > > ---
