Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2021-01-07 Thread Ashish Sadanandan
Hi David, On Thu, Jan 7, 2021 at 1:02 AM David Marchand wrote: > On Thu, Jan 7, 2021 at 2:42 AM Ashish Sadanandan > wrote: > > > > Hi Olivier, > > > > On Wed, Jan 6, 2021 at 6:21 AM Olivier Matz > wrote: > > > > > > Hi Ashish, > > > > > > Yes, it should reference the patch that introduced the

Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2021-01-07 Thread David Marchand
On Thu, Jan 7, 2021 at 2:42 AM Ashish Sadanandan wrote: > > Hi Olivier, > > On Wed, Jan 6, 2021 at 6:21 AM Olivier Matz wrote: > > > > Hi Ashish, > > > > Yes, it should reference the patch that introduced the issue. In this case, > > it should be: > > > > Fixes: 4958ca3a443a ("mbuf: support dyn

Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2021-01-06 Thread Ashish Sadanandan
Hi Olivier, On Wed, Jan 6, 2021 at 6:21 AM Olivier Matz wrote: > > Hi Ashish, > > Yes, it should reference the patch that introduced the issue. In this case, > it should be: > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > > Can you please also change the title to start with

Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2021-01-06 Thread Olivier Matz
Hi Ashish, On Tue, Dec 29, 2020 at 01:22:04PM -0700, Ashish Sadanandan wrote: > Hi Stephen, > Should I reference the commit that created rte_mbuf_dyn.h for the Fixes tag? Yes, it should reference the patch that introduced the issue. In this case, it should be: Fixes: 4958ca3a443a ("mbuf: suppo

Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2020-12-29 Thread Ashish Sadanandan
Hi Stephen, Should I reference the commit that created rte_mbuf_dyn.h for the Fixes tag? PS: this is my first time submitting a patch to DPDK, so forgive me if this is covered in the contributing doc, but I couldn't find anything that applied to this situation On Tue, Dec 29, 2020 at 1:10 PM Step

Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h

2020-12-29 Thread Stephen Hemminger
On Tue, 29 Dec 2020 12:41:44 -0700 Ashish Sadanandan wrote: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Signed-off-by: Ashish Sadanandan Coul