On Thu, Jan 7, 2021 at 2:42 AM Ashish Sadanandan <ashish.sadanan...@gmail.com> wrote: > > Hi Olivier, > > On Wed, Jan 6, 2021 at 6:21 AM Olivier Matz <olivier.m...@6wind.com> wrote: > > > > Hi Ashish, > > > > Yes, it should reference the patch that introduced the issue. In this case, > > it should be: > > > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > > > > Can you please also change the title to start with "fix", for > > instance like this: > > > > mbuf: fix inclusion from c++ > > > > You can also add "Cc: sta...@dpdk.org" in the commit log. > > > > Some documentation can be found in doc/guides/contributing/patches.rst > > Thanks for the pointers. I've made the changes above. However I don't > know if I'm using the message ID for --in-reply-to correctly, since I > seem to be creating a new thread each time.
You can get the message ID in various places. I usually take the info from patchwork and update the previous patch state to Superseded at the same time. So in your case, the v1 patch was: http://patchwork.dpdk.org/patch/85878/ Message ID: 20201229194144.17824-1-ashish.sadanan...@gmail.com So for the v2: git send-email --to dev@dpdk.org --cc-cmd ./devtools/get-maintainer.sh --cc XXX --in-reply-to '20201229194144.17824-1-ashish.sadanan...@gmail.com' v2-*.patch -- David Marchand