Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-21 Thread Maxime Coquelin
On 3/20/19 6:50 PM, Stephen Hemminger wrote: On Wed, 20 Mar 2019 12:40:26 +0800 Tiwei Bie wrote: I agree the vq_ prefix is not needed and I think the code is more readable in general seeing the packed/split name when using the struct. Please also consider that cosmetic changes in multiple

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-20 Thread Stephen Hemminger
On Wed, 20 Mar 2019 12:40:26 +0800 Tiwei Bie wrote: > > I agree the vq_ prefix is not needed and I think the code is more > > readable in general seeing the packed/split name when using the struct. > > > > Please also consider that cosmetic changes in multiple places likely > > mean backports wi

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Tiwei Bie
On Tue, Mar 19, 2019 at 02:59:38PM +, Kevin Traynor wrote: > On 19/03/2019 13:50, Maxime Coquelin wrote: > > > > > > On 3/19/19 2:47 PM, Jens Freimann wrote: > >> On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: > >>> > >>> > >>> On 3/19/19 11:09 AM, Tiwei Bie wrote: > On

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Tiwei Bie
On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: > On 3/19/19 11:09 AM, Tiwei Bie wrote: > > On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: > > > On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: > > > > Put split ring and packed ring specific fields into se

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Kevin Traynor
On 19/03/2019 13:50, Maxime Coquelin wrote: > > > On 3/19/19 2:47 PM, Jens Freimann wrote: >> On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: >>> >>> >>> On 3/19/19 11:09 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: > On Tue, Mar 19

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Maxime Coquelin
On 3/19/19 2:47 PM, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: On 3/19/19 11:09 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: Put split ring and pac

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote: On 3/19/19 11:09 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: Put split ring and packed ring specific fields into separate sub-st

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Maxime Coquelin
On 3/19/19 7:43 AM, Tiwei Bie wrote: Put split ring and packed ring specific fields into separate sub-structures, and also union them as they won't be available at the same time. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 71 +- drivers/net

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Maxime Coquelin
On 3/19/19 11:09 AM, Tiwei Bie wrote: On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: Put split ring and packed ring specific fields into separate sub-structures, and also union them as they won't be available at the s

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Tiwei Bie
On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote: > On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: > > Put split ring and packed ring specific fields into separate > > sub-structures, and also union them as they won't be available > > at the same time. > > > > Signed-off-b

Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure

2019-03-19 Thread Jens Freimann
On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote: Put split ring and packed ring specific fields into separate sub-structures, and also union them as they won't be available at the same time. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 71 +--