Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-28 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wenzhuo Lu > Sent: Thursday, April 29, 2021 9:34 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/iavf: fix performance drop > > The performance drop is caused by that the RX scalar path is selected when > AVX512 i

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-28 Thread Lu, Wenzhuo
> The fix by not changing Rx implementation, but making sure correct Rx path > selected, right? Can you please clarify this in the commit log? > > So the performance drop fixed for whoever have the vector path supported and > offloads enabled, can be good to highlight in the patch title, otherwise

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-28 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, April 28, 2021 7:32 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop > > On 4/27/2021 3:57 AM, Zhang, Qi Z wrote: > >

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-28 Thread Ferruh Yigit
On 4/27/2021 3:57 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Lu, Wenzhuo >> Sent: 2021年4月27日 9:51 >> To: Zhang, Qi Z ; dev@dpdk.org >> Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix performance drop >> >>>>

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-28 Thread Ferruh Yigit
On 4/26/2021 6:29 AM, Wenzhuo Lu wrote: > AVX2 and SSE don't have the offload path. > Not necessary doing any check. Or the scalar path > will be chosen. Hi Wenzhuo, The fix by not changing Rx implementation, but making sure correct Rx path selected, right? Can you please clarify this in the comm

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wenzhuo Lu > Sent: Monday, April 26, 2021 1:30 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/iavf: fix performance drop > > AVX2 and SSE don't have the offload path. > Not necessary doing any check. Or the scala

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-26 Thread Lu, Wenzhuo
> > > > +use_sse = true; > > > > +if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 || > > > > + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) && > > > > +rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256) > > > > +use_avx2 = true; > > > > > > > > > Not sure if the right path w

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: Lu, Wenzhuo > Sent: 2021年4月27日 9:51 > To: Zhang, Qi Z ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix performance drop > > > > +use_sse = true; > > > +if ((rte_cpu_get

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-26 Thread Lu, Wenzhuo
> > +use_sse = true; > > +if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 || > > + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) && > > +rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256) > > +use_avx2 = true; > > > Not sure if the right path will be selected when avx512 is

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop

2021-04-26 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wenzhuo Lu > Sent: Monday, April 26, 2021 1:30 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/iavf: fix performance drop > > AVX2 and SSE don't have the offload path. > Not necessary doing any check. Or the scala

Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop after port reset

2020-11-12 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Thursday, November 12, 2020 1:52 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > ; Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH] net/iavf: fix performance drop after port reset > > Needs to reset rxq->rxrearm_star