Re: [dpdk-dev] [PATCH] net/enic: add primary mac address handler

2018-04-13 Thread Ferruh Yigit
On 4/6/2018 6:33 PM, Ferruh Yigit wrote: > On 2/20/2018 12:16 PM, Hyong Youb Kim wrote: >> On Tue, Feb 20, 2018 at 10:17:34AM +0100, David Marchand wrote: >> [...] >>> Btw, I had forgotten about the deprecation notice [1] sent by Olivier. >>> Just discussed it with him, let's wait for this change b

Re: [dpdk-dev] [PATCH] net/enic: add primary mac address handler

2018-04-06 Thread Ferruh Yigit
On 2/20/2018 12:16 PM, Hyong Youb Kim wrote: > On Tue, Feb 20, 2018 at 10:17:34AM +0100, David Marchand wrote: > [...] >> Btw, I had forgotten about the deprecation notice [1] sent by Olivier. >> Just discussed it with him, let's wait for this change before looking >> at the issue again. >> >> >> 1

Re: [dpdk-dev] [PATCH] net/enic: add primary mac address handler

2018-02-20 Thread Hyong Youb Kim
On Tue, Feb 20, 2018 at 10:17:34AM +0100, David Marchand wrote: [...] > Btw, I had forgotten about the deprecation notice [1] sent by Olivier. > Just discussed it with him, let's wait for this change before looking > at the issue again. > > > 1: > http://dpdk.org/browse/dpdk/commit/doc?id=16a700

Re: [dpdk-dev] [PATCH] net/enic: add primary mac address handler

2018-02-20 Thread David Marchand
Hello, On Tue, Feb 20, 2018 at 6:41 AM, Hyong Youb Kim wrote: > On Mon, Feb 19, 2018 at 01:42:27PM +0100, David Marchand wrote: >> Reused the .mac_addr_add and .mac_addr_del callbacks code to implement >> primary mac address handler. >> >> Signed-off-by: David Marchand > > Hi, thanks for taking

Re: [dpdk-dev] [PATCH] net/enic: add primary mac address handler

2018-02-19 Thread Hyong Youb Kim
On Mon, Feb 19, 2018 at 01:42:27PM +0100, David Marchand wrote: > Reused the .mac_addr_add and .mac_addr_del callbacks code to implement > primary mac address handler. > > Signed-off-by: David Marchand Hi, thanks for taking a stab at this. > +static void enicpmd_set_mac_addr(struct rte_eth_dev