Hello,
On Tue, Feb 20, 2018 at 6:41 AM, Hyong Youb Kim <hyon...@cisco.com> wrote:
> On Mon, Feb 19, 2018 at 01:42:27PM +0100, David Marchand wrote:
>> Reused the .mac_addr_add and .mac_addr_del callbacks code to implement
>> primary mac address handler.
>>
>> Signed-off-by: David Marchand <david.march...@6wind.com>
>
> Hi, thanks for taking a stab at this.
>
>> +static void enicpmd_set_mac_addr(struct rte_eth_dev *eth_dev,
>> + struct ether_addr *addr)
>> +{
>> + enicpmd_remove_mac_addr(eth_dev, 0);
>> + enicpmd_add_mac_addr(eth_dev, addr, 0, 0);
>> +}
>
> Unfortunately, this does not work as expected. The caller updates
> mac_addrs[0] prior to calling mac_addr_set.
Indeed.
Btw, I had forgotten about the deprecation notice [1] sent by Olivier.
Just discussed it with him, let's wait for this change before looking
at the issue again.
1:
http://dpdk.org/browse/dpdk/commit/doc?id=16a7009aeed5836d671aada0d9fe11b20a4c3ce5
--
David Marchand
