Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-05-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, May 8, 2018 8:51 PM > To: Dumitrescu, Cristian > Cc: Zhang, Roy Fan ; dev@dpdk.org; Singh, > Jasvinder > Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null > terminated >

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-05-08 Thread Bruce Richardson
On Tue, May 08, 2018 at 02:28:25PM +, Dumitrescu, Cristian wrote: > > > > -Original Message- > > From: Zhang, Roy Fan > > Sent: Monday, April 16, 2018 12:03 PM > > To: dev@dpdk.org > > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > > > > Subject: [PATCH] examples/ip_pipeline: fix buff

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-05-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, April 16, 2018 12:03 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > > Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated > > Coverity issue: 272572 > Fixes: 719374345cee ("examples/ip_p

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated.

2018-05-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, April 16, 2018 11:26 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > > Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated. > > Coverity issue: 272563 > Fixes: 8245472c58c8 ("examples/ip_

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-19 Thread Singh, Jasvinder
> -Original Message- > From: Laatz, Kevin > Sent: Thursday, April 19, 2018 12:01 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Laatz, Kevin > ; Singh, Jasvinder > Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated > > The destination string may not have a NULL te

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-19 Thread Singh, Jasvinder
> -Original Message- > From: Laatz, Kevin > Sent: Thursday, April 19, 2018 12:03 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Laatz, Kevin > ; Singh, Jasvinder > Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated > > The destination string may not have a NULL te

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-19 Thread Singh, Jasvinder
> -Original Message- > From: Pattan, Reshma > Sent: Wednesday, April 18, 2018 5:58 PM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Pattan, Reshma > > Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated > > Copying source string of length equal to sizeof(kni->name) will

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-19 Thread Singh, Jasvinder
> -Original Message- > From: Pattan, Reshma > Sent: Wednesday, April 18, 2018 5:58 PM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Pattan, Reshma > > Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated > > Copying source string of length equal to sizeof(profile->name) w

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-17 Thread Singh, Jasvinder
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, April 17, 2018 4:01 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null > terminated > > On Tue, Apr 1

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-17 Thread Bruce Richardson
On Tue, Apr 17, 2018 at 02:28:25PM +0100, Jasvinder Singh wrote: > The destination string may not have a null termination if > the source string's length is equal to the sizeof(pipeline->name). > > Fix by replacing strncpy with strlcpy that guarantees NULL-termination. > > Coverty issue: 272606 >

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-17 Thread Bruce Richardson
On Tue, Apr 17, 2018 at 02:17:19PM +0100, Jasvinder Singh wrote: > The destination string may not have a null termination if > the source string's length is equal to the sizeof(tap->name). > > Fix by replacing strncpy with strlcpy that guarantees NULL-termination. > > Coverty issue: 272603 > Fixe

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-16 Thread Bruce Richardson
On Mon, Apr 16, 2018 at 12:02:33PM +0100, Fan Zhang wrote: > Coverity issue: 272572 > Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects") > > Signed-off-by: Fan Zhang > --- > examples/ip_pipeline/action.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi