> -----Original Message-----
> From: Pattan, Reshma
> Sent: Wednesday, April 18, 2018 5:58 PM
> To: dev@dpdk.org
> Cc: Singh, Jasvinder <jasvinder.si...@intel.com>; Pattan, Reshma
> <reshma.pat...@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix buffer not null terminated
>
> Copying source string of length equal to sizeof(profile->name) will not append
> the NULL in destination.
>
> Using strlcpy in place of strncpy fixes this issue as strlcpy guarantees NULL
> termination.
>
> Coverity issue: 272580
> Fixes: 719374345c ("examples/ip_pipeline: add action profile objects")
> CC: jasvinder.si...@intel.com
>
> Signed-off-by: Reshma Pattan <reshma.pat...@intel.com>
> ---
> examples/ip_pipeline/action.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c
> index 77a04fe19..d2cd7286c 100644
> --- a/examples/ip_pipeline/action.c
> +++ b/examples/ip_pipeline/action.c
> @@ -6,6 +6,8 @@
> #include <stdlib.h>
> #include <string.h>
>
> +#include <rte_string_fns.h>
> +
> #include "action.h"
> #include "hash_func.h"
>
> @@ -345,7 +347,7 @@ table_action_profile_create(const char *name,
> }
>
> /* Node fill in */
> - strncpy(profile->name, name, sizeof(profile->name));
> + strlcpy(profile->name, name, sizeof(profile->name));
> memcpy(&profile->params, params, sizeof(*params));
> profile->ap = ap;
>
> --
> 2.14.3
Reviewed-by: Jasvinder Singh <jasvinder.si...@intel.com>
