Re: [dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value

2018-03-21 Thread Arnon Warshavsky
I don't know what needs to be modified. > I think the first step is to clearly identified the different kind > of changes by splitting your patch. > Then we will decide how to integrate them. > > > Ok.Will split the commit with no abi handling and continue from there

Re: [dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value

2018-03-21 Thread Thomas Monjalon
21/03/2018 00:04, Arnon Warshavsky: > > > > You are talking about API, and I agree the old applications can keep > > considering the functions as void. > > But I was talking about ABI, meaning: can we use an old application > > without recompiling and update only the DPDK (in .so file)? > > > > > >

Re: [dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value

2018-03-20 Thread Arnon Warshavsky
> > You are talking about API, and I agree the old applications can keep > considering the functions as void. > But I was talking about ABI, meaning: can we use an old application > without recompiling and update only the DPDK (in .so file)? > > > You are right of course. Once again I mixed the two

Re: [dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value

2018-03-20 Thread Thomas Monjalon
20/03/2018 23:42, Arnon Warshavsky: > > Thanks for working on this important topic. > > With pleasure :) > > > My feeling is that we could replace most of them by a log + return. > > I did not think you would add a new macro. Why you chose this way? > > This was meant to keep the code shorter, a

Re: [dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value

2018-03-20 Thread Arnon Warshavsky
> Thanks for working on this important topic. > With pleasure :) > ... > My feeling is that we could replace most of them by a log + return. > I did not think you would add a new macro. Why you chose this way? > This was meant to keep the code shorter, and imply to the reader that this > return i

Re: [dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value

2018-03-20 Thread Thomas Monjalon
Hi, 20/03/2018 22:28, Arnon Warshavsky: > The purpose of this patch is to cleanup the library code > from paths that end up aborting the process, > and move to checking error values, in order to allow the running process > perform an orderly teardown or other mitigation of the event. Thanks for w