Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-22 Thread Ray Kinsella
On 21/04/2020 10:36, Thomas Monjalon wrote: > 21/04/2020 08:01, Ray Kinsella: >> >> On 20/04/2020 18:37, Thomas Monjalon wrote: >>> 20/04/2020 19:31, Ray Kinsella: Our only commitment is to the stability of the v19.11/v20 ABI, until v21. That said, once an ABI migrates from

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-21 Thread Thomas Monjalon
21/04/2020 08:01, Ray Kinsella: > > On 20/04/2020 18:37, Thomas Monjalon wrote: > > 20/04/2020 19:31, Ray Kinsella: > >> > >> Our only commitment is to the stability of the v19.11/v20 ABI, until v21. > >> > >> That said, once an ABI migrates from EXPERIMENTAL to v21, it _shouldn't_ > >> be chang

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-20 Thread Ray Kinsella
On 20/04/2020 18:37, Thomas Monjalon wrote: > 20/04/2020 19:31, Ray Kinsella: >> >> Our only commitment is to the stability of the v19.11/v20 ABI, until v21. >> >> That said, once an ABI migrates from EXPERIMENTAL to v21, it _shouldn't_ be >> changing. >> We don't have a strict commitment to t

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-20 Thread Thomas Monjalon
20/04/2020 19:31, Ray Kinsella: > > Our only commitment is to the stability of the v19.11/v20 ABI, until v21. > > That said, once an ABI migrates from EXPERIMENTAL to v21, it _shouldn't_ be > changing. > We don't have a strict commitment to the v21 ABI until v20.11. > > However if v21 is chang

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-20 Thread Ray Kinsella
: Thomas Monjalon ; Richardson, Bruce >>> >>> Cc: Trahe, Fiona ; dev@dpdk.org; Kusztal, ArkadiuszX >>> ; Neil Horman ; Luca >>> Boccassi >>> ; Kevin Traynor ; Yigit, Ferruh >>> >>> Subject: Re: [dpdk-dev] [PATCH] cryptodev: version

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-20 Thread Trahe, Fiona
t; Richardson, Bruce > > Cc: dev@dpdk.org; Kusztal, ArkadiuszX ; Neil > Horman > ; Luca Boccassi ; Kevin Traynor > ; Yigit, Ferruh ; Trahe, Fiona > > Subject: RE: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get > function > > Hi all, > > >

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-17 Thread Ray Kinsella
iuszX >> ; Neil Horman ; Luca >> Boccassi >> ; Kevin Traynor ; Yigit, Ferruh >> >> Subject: Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get >> function >> >> >> >> On 17/04/2020 11:17, Thomas Monjalon wrote: >>> 17/

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-17 Thread Trahe, Fiona
> > Subject: Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get > function > > > > On 17/04/2020 11:17, Thomas Monjalon wrote: > > 17/04/2020 11:42, Ray Kinsella: > >> On 17/04/2020 10:31, Bruce Richardson wrote: > >>> On Fri, Apr 1

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-17 Thread Ray Kinsella
On 17/04/2020 11:17, Thomas Monjalon wrote: > 17/04/2020 11:42, Ray Kinsella: >> On 17/04/2020 10:31, Bruce Richardson wrote: >>> On Fri, Apr 17, 2020 at 08:24:30AM +0100, Ray Kinsella wrote: On 16/04/2020 11:01, Thomas Monjalon wrote: > 16/04/2020 11:51, Bruce Richardson: >> On Wed

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-17 Thread Thomas Monjalon
17/04/2020 11:42, Ray Kinsella: > On 17/04/2020 10:31, Bruce Richardson wrote: > > On Fri, Apr 17, 2020 at 08:24:30AM +0100, Ray Kinsella wrote: > >> On 16/04/2020 11:01, Thomas Monjalon wrote: > >>> 16/04/2020 11:51, Bruce Richardson: > On Wed, Apr 15, 2020 at 06:24:19PM +0100, Trahe, Fiona w

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-17 Thread Ray Kinsella
On 17/04/2020 10:31, Bruce Richardson wrote: > On Fri, Apr 17, 2020 at 08:24:30AM +0100, Ray Kinsella wrote: >> >> >> On 16/04/2020 11:01, Thomas Monjalon wrote: >>> 16/04/2020 11:51, Bruce Richardson: On Wed, Apr 15, 2020 at 06:24:19PM +0100, Trahe, Fiona wrote: > 5a. If in 20.05 we ad

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-17 Thread Bruce Richardson
On Fri, Apr 17, 2020 at 08:24:30AM +0100, Ray Kinsella wrote: > > > On 16/04/2020 11:01, Thomas Monjalon wrote: > > 16/04/2020 11:51, Bruce Richardson: > >> On Wed, Apr 15, 2020 at 06:24:19PM +0100, Trahe, Fiona wrote: > >>> 5a. If in 20.05 we add a version of a fn which breaks ABI 20.0, what >

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-17 Thread Ray Kinsella
On 16/04/2020 11:01, Thomas Monjalon wrote: > 16/04/2020 11:51, Bruce Richardson: >> On Wed, Apr 15, 2020 at 06:24:19PM +0100, Trahe, Fiona wrote: >>> 5a. If in 20.05 we add a version of a fn which breaks ABI 20.0, what should >>> the name of the original function be? fn_v20, or fn_v20.0 >> >>

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-16 Thread Thomas Monjalon
16/04/2020 11:51, Bruce Richardson: > On Wed, Apr 15, 2020 at 06:24:19PM +0100, Trahe, Fiona wrote: > > 5a. If in 20.05 we add a version of a fn which breaks ABI 20.0, what should > > the name of the original function be? fn_v20, or fn_v20.0 > > In technical terms it really doesn't matter, it's j

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-16 Thread Bruce Richardson
uot;sticks" and belongs to the > new ABI which then must remain stable til 21.11 For functions that are part of the stable ABI, each change requires a new version, since there is an expectation that 20.05 builds will also work with 20.08. Regards, /Bruce > > > > -Or

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-15 Thread Trahe, Fiona
Trahe, Fiona > Sent: Tuesday, April 14, 2020 7:27 PM > To: Ray Kinsella ; dev@dpdk.org > Cc: Trahe, Fiona ; Kusztal, ArkadiuszX > > Subject: RE: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get > function > > Hi Ray, > > We're going to n

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-14 Thread Trahe, Fiona
e- > From: dev On Behalf Of Ray Kinsella > Sent: Tuesday, April 14, 2020 2:54 PM > To: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get > function > > > > On 18/03/2020 20:41, Arek Kusztal wrote: > > This patch adds

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-14 Thread Ray Kinsella
On 18/03/2020 20:41, Arek Kusztal wrote: > This patch adds versioned function rte_cryptodev_info_get. > Node 20.05 function works the same way it was working before. > Node 20.0 function strips capability added in 20.05 release > to prevent some issues with ABI policy. To do that new capability

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-14 Thread Trahe, Fiona
Hi Akhil, Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 14, 2020 2:04 PM > To: Kusztal, ArkadiuszX > Cc: Ray Kinsella ; Richardson, Bruce > ; dev@dpdk.org; > Trahe, Fiona ; dev@dpdk.org; Akhil Goyal > > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-14 Thread Thomas Monjalon
14/04/2020 14:13, Akhil Goyal: > Hi Ray/Thomas/Bruce, > > Could you please help review this patch wrt ABI policy? > > > > This patch adds versioned function rte_cryptodev_info_get. > > Node 20.05 function works the same way it was working before. > > Node 20.0 function strips capability added in

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-14 Thread Akhil Goyal
Hi Ray/Thomas/Bruce, Could you please help review this patch wrt ABI policy? > > This patch adds versioned function rte_cryptodev_info_get. > Node 20.05 function works the same way it was working before. > Node 20.0 function strips capability added in 20.05 release > to prevent some issues with A