Re: [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC

2023-05-04 Thread Ferruh Yigit
On 5/4/2023 8:13 AM, Denis Pryazhennikov wrote: > I think my patch isn't correct. > I would say that > - fec_capa is a set of bits produced by 'RTE_ETH_FEC_MODE_TO_CAPA()'; > - fec_mode is an element of 'enum rte_eth_fec_mode'. > > Based on this definition, replacing 'fec_capa' with 'fec_mode' sho

Re: [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC

2023-05-04 Thread Denis Pryazhennikov
I think my patch isn't correct. I would say that - fec_capa is a set of bits produced by 'RTE_ETH_FEC_MODE_TO_CAPA()'; - fec_mode is an element of 'enum rte_eth_fec_mode'. Based on this definition, replacing 'fec_capa' with 'fec_mode' should involve changing the parameter type. Probably I should

Re: [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC

2023-05-02 Thread Ferruh Yigit
On 4/28/2023 11:27 AM, Denis Pryazhennikov wrote: > Only one valid FEC mode can be get by rte_eth_fec_get(). > The previous name implied that more than one FEC mode > can be obtained. +1 and patch looks good. But isn't this valid for 'rte_eth_fec_set()', it gets 'fec_mode'. FEC capability has its