Re: [PATCH v3 4/6] argparse: fix argument flags operate as uint32 type

2024-03-18 Thread fengchengwen
Hi Thomas, On 2024/3/18 17:38, Thomas Monjalon wrote: > 18/03/2024 10:18, Chengwen Feng: >> --- a/app/test/test_argparse.c >> +++ b/app/test/test_argparse.c >> +#define TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK RTE_SHIFT_VAL64(3, 0) >> +#define TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK RTE_SHIFT_VAL64(255, 2)

Re: [PATCH v3 4/6] argparse: fix argument flags operate as uint32 type

2024-03-18 Thread Thomas Monjalon
18/03/2024 10:18, Chengwen Feng: > --- a/app/test/test_argparse.c > +++ b/app/test/test_argparse.c > +#define TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK RTE_SHIFT_VAL64(3, 0) > +#define TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK RTE_SHIFT_VAL64(255, 2) Don't you want to make it part of the API? I thought it w