Re: [PATCH v2 1/1] ethdev: support congestion management

2022-09-28 Thread Olivier Matz
On Wed, Sep 28, 2022 at 05:53:06PM +0530, Jerin Jacob wrote: > On Wed, Sep 28, 2022 at 5:38 PM Thomas Monjalon wrote: > > > > 28/09/2022 13:14, Jerin Jacob: > > > On Tue, Sep 27, 2022 at 8:39 PM Bruce Richardson > > > wrote: > > > > > > > > On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalo

Re: [PATCH v2 1/1] ethdev: support congestion management

2022-09-28 Thread Jerin Jacob
On Wed, Sep 28, 2022 at 5:38 PM Thomas Monjalon wrote: > > 28/09/2022 13:14, Jerin Jacob: > > On Tue, Sep 27, 2022 at 8:39 PM Bruce Richardson > > wrote: > > > > > > On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote: > > > > > > > ++ > > > > > > > > I feel EAL is not the right plac

Re: [PATCH v2 1/1] ethdev: support congestion management

2022-09-28 Thread Jerin Jacob
On Wed, Sep 28, 2022 at 1:50 PM Andrew Rybchenko wrote: > > Cc David. See some kind of reincarnation of RTE_FUNC_PTR_* > macro below. > > > + > > +/** > > + * @file > > + * Congestion management related parameters for DPDK. > > + */ > > + > > +/** Congestion management modes */ > > +enum rte_cman

Re: [PATCH v2 1/1] ethdev: support congestion management

2022-09-28 Thread Thomas Monjalon
28/09/2022 13:14, Jerin Jacob: > On Tue, Sep 27, 2022 at 8:39 PM Bruce Richardson > wrote: > > > > On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote: > > > > > ++ > > > > > > I feel EAL is not the right place for CMAN definitions. > > > > > > After a discussion with Jerin, I unders

Re: [PATCH v2 1/1] ethdev: support congestion management

2022-09-28 Thread Jerin Jacob
On Tue, Sep 27, 2022 at 8:39 PM Bruce Richardson wrote: > > On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote: > > > ++ > > > > I feel EAL is not the right place for CMAN definitions. > > > > After a discussion with Jerin, I understand we could use the same > > definitions in other

Re: [PATCH v2 1/1] ethdev: support congestion management

2022-09-28 Thread Andrew Rybchenko
Cc David. See some kind of reincarnation of RTE_FUNC_PTR_* macro below. On 9/19/22 15:15, sk...@marvell.com wrote: From: Jerin Jacob NIC HW controllers often come with congestion management support on various HW objects such as Rx queue depth or mempool queue depth. Also, it can support vario

Re: [PATCH v2 1/1] ethdev: support congestion management

2022-09-27 Thread Bruce Richardson
On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote: > 19/09/2022 14:15, sk...@marvell.com: > > From: Jerin Jacob > > > > NIC HW controllers often come with congestion management support on > > various HW objects such as Rx queue depth or mempool queue depth. > > > > Also, it can sup

Re: [PATCH v2 1/1] ethdev: support congestion management

2022-09-27 Thread Thomas Monjalon
19/09/2022 14:15, sk...@marvell.com: > From: Jerin Jacob > > NIC HW controllers often come with congestion management support on > various HW objects such as Rx queue depth or mempool queue depth. > > Also, it can support various modes of operation such as RED > (Random early discard), WRED etc