On Wed, Sep 28, 2022 at 05:53:06PM +0530, Jerin Jacob wrote: > On Wed, Sep 28, 2022 at 5:38 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > > > 28/09/2022 13:14, Jerin Jacob: > > > On Tue, Sep 27, 2022 at 8:39 PM Bruce Richardson > > > <bruce.richard...@intel.com> wrote: > > > > > > > > On Tue, Sep 27, 2022 at 04:36:18PM +0200, Thomas Monjalon wrote: > > > > > > > > > ++ > > > > > > > > > > I feel EAL is not the right place for CMAN definitions. > > > > > > > > > > After a discussion with Jerin, I understand we could use the same > > > > > definitions in other API classes, not only ethdev. However I think > > > > > this > > > > > .h file should be better hosted in lib/ethdev/ with its own namespace > > > > > rte_cman. Then other libs could include this rte_cman.h without > > > > > having a > > > > > strong dependency on ethdev. > > > > > > > > > > Deal? > > > > > > > > > Would rte_net also be an option? Alternatively, is this related to the > > > > work > > > > > > Looks like the net is a good option. Since it is just a header file > > > any place would be OK. > > > > > > + @Olivier Matz > > > > > > Any objections to keeping rte_cman.h to lib/net? > > > > lib/net/ is supposed to be standardized packet headers definitions. > > Since it had lib/net/net_crc.h, I thought it is OK to keep it in lib/net. > No strong opinion. I will keep it as lib/ethdev/rte_cman.h then.
lib/ethdev/rte_cman.h looks better to me too.
