Re: [PATCH v1 2/2] dts: checksum offload test suite

2024-08-19 Thread Dean Marx
> > > > +def send_packet_and_verify( > > Should this not be `send_packets_and_verify(` as the argument is > `packet_list`. > Yeah that would definitely make more sense, I'll change that in the next version. > > > +isL4 = any( > > +VerboseOLFlag.RTE_MBUF_F_RX_L4_CKSUM_GO

Re: [PATCH v1 2/2] dts: checksum offload test suite

2024-08-19 Thread Alex Chapman
Hi Dean, Just though I would point out a few things. On 8/16/24 15:20, Dean Marx wrote: +def send_packet_and_verify( Should this not be `send_packets_and_verify(` as the argument is `packet_list`. +isL4 = any( +VerboseOLFlag.RTE_MBUF_F_RX_L4_CKSUM_GOOD in packet.ol