Hi Dean, Just though I would point out a few things.
On 8/16/24 15:20, Dean Marx wrote: <snip>
+ def send_packet_and_verify(
Should this not be `send_packets_and_verify(` as the argument is `packet_list`. <snip>
+ isL4 = any( + VerboseOLFlag.RTE_MBUF_F_RX_L4_CKSUM_GOOD in packet.ol_flags + for index in verbose_output + for packet in index.packets + )
How does this filter out noise packets with valid checksums?
+ isIP = any( + VerboseOLFlag.RTE_MBUF_F_RX_IP_CKSUM_GOOD in packet.ol_flags + for index in verbose_output + for packet in index.packets + )
As above I also noticed there was no implementation of IPv6/SCTP. Although the old test suite did not include IPv6/SCTP, would it be worth adding it to the new test suite? It was included in the test plan, but never implemented for some reason. Best regards, Alex
