Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-11 Thread Tyler Retzlaff
On Tue, Apr 11, 2023 at 10:10:48AM +0100, Bruce Richardson wrote: > On Mon, Apr 10, 2023 at 01:58:48PM -0700, Tyler Retzlaff wrote: > > On Mon, Apr 10, 2023 at 09:02:00PM +0100, Konstantin Ananyev wrote: > > > 06/04/2023 01:07, Tyler Retzlaff пишет: > > > >On Wed, Apr 05, 2023 at 10:57:02AM +,

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-11 Thread Bruce Richardson
On Mon, Apr 10, 2023 at 01:58:48PM -0700, Tyler Retzlaff wrote: > On Mon, Apr 10, 2023 at 09:02:00PM +0100, Konstantin Ananyev wrote: > > 06/04/2023 01:07, Tyler Retzlaff пишет: > > >On Wed, Apr 05, 2023 at 10:57:02AM +, Konstantin Ananyev wrote: > > >> > > >>>Inline assembly is not support

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-10 Thread Tyler Retzlaff
On Mon, Apr 10, 2023 at 09:02:00PM +0100, Konstantin Ananyev wrote: > 06/04/2023 01:07, Tyler Retzlaff пишет: > >On Wed, Apr 05, 2023 at 10:57:02AM +, Konstantin Ananyev wrote: > >> > >>>Inline assembly is not supported for msvc x64 instead use > >>>_{Read,Write,ReadWrite}Barrier() intr

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-10 Thread Konstantin Ananyev
06/04/2023 01:07, Tyler Retzlaff пишет: On Wed, Apr 05, 2023 at 10:57:02AM +, Konstantin Ananyev wrote: Inline assembly is not supported for msvc x64 instead use _{Read,Write,ReadWrite}Barrier() intrinsics. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_atomic.h | 4 +++

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-10 Thread Konstantin Ananyev
05/04/2023 16:38, Tyler Retzlaff пишет: On Wed, Apr 05, 2023 at 02:35:47PM +0200, Morten Brørup wrote: From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] Sent: Wednesday, 5 April 2023 12.57 Another ore generic comment - do we really need to pollute all that code with RTE_TOOLCHAI

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-05 Thread Tyler Retzlaff
On Wed, Apr 05, 2023 at 10:57:02AM +, Konstantin Ananyev wrote: > > > > >>>Inline assembly is not supported for msvc x64 instead use > > > >>>_{Read,Write,ReadWrite}Barrier() intrinsics. > > > >>> > > > >>>Signed-off-by: Tyler Retzlaff > > > >>>--- > > > >>> lib/eal/include/generic/rte_atomi

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-05 Thread Tyler Retzlaff
On Wed, Apr 05, 2023 at 02:35:47PM +0200, Morten Brørup wrote: > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Wednesday, 5 April 2023 12.57 > > > > > > >>Another ore generic comment - do we really need to pollute all that > > > > >>code > > with RTE_TOOLCHAIN_MSVC i

RE: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-05 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Wednesday, 5 April 2023 12.57 > > > > >>Another ore generic comment - do we really need to pollute all that code > with RTE_TOOLCHAIN_MSVC ifdefs? > > > >>Right now we have ability to have subdir per arch (x86/arm/etc.). > >

RE: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-05 Thread Konstantin Ananyev
> > >>>Inline assembly is not supported for msvc x64 instead use > > >>>_{Read,Write,ReadWrite}Barrier() intrinsics. > > >>> > > >>>Signed-off-by: Tyler Retzlaff > > >>>--- > > >>> lib/eal/include/generic/rte_atomic.h | 4 > > >>> lib/eal/x86/include/rte_atomic.h | 10 +- > > >>

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-04 Thread Tyler Retzlaff
On Wed, Apr 05, 2023 at 12:49:21AM +0100, Konstantin Ananyev wrote: > 04/04/2023 16:49, Tyler Retzlaff пишет: > >On Tue, Apr 04, 2023 at 12:11:07PM +, Konstantin Ananyev wrote: > >> > >> > >>>Inline assembly is not supported for msvc x64 instead use > >>>_{Read,Write,ReadWrite}Barrier() intrins

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-04 Thread Konstantin Ananyev
04/04/2023 16:49, Tyler Retzlaff пишет: On Tue, Apr 04, 2023 at 12:11:07PM +, Konstantin Ananyev wrote: Inline assembly is not supported for msvc x64 instead use _{Read,Write,ReadWrite}Barrier() intrinsics. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_atomic.h | 4 ++

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-04 Thread Tyler Retzlaff
On Tue, Apr 04, 2023 at 05:23:07PM +0100, Bruce Richardson wrote: > On Tue, Apr 04, 2023 at 08:43:01AM -0700, Tyler Retzlaff wrote: > > On Tue, Apr 04, 2023 at 09:53:21AM +0100, Bruce Richardson wrote: > > > On Mon, Apr 03, 2023 at 02:52:25PM -0700, Tyler Retzlaff wrote: > > > > Inline assembly is

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-04 Thread Bruce Richardson
On Tue, Apr 04, 2023 at 08:43:01AM -0700, Tyler Retzlaff wrote: > On Tue, Apr 04, 2023 at 09:53:21AM +0100, Bruce Richardson wrote: > > On Mon, Apr 03, 2023 at 02:52:25PM -0700, Tyler Retzlaff wrote: > > > Inline assembly is not supported for msvc x64 instead use > > > _{Read,Write,ReadWrite}Barrie

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-04 Thread Tyler Retzlaff
On Tue, Apr 04, 2023 at 12:11:07PM +, Konstantin Ananyev wrote: > > > > Inline assembly is not supported for msvc x64 instead use > > _{Read,Write,ReadWrite}Barrier() intrinsics. > > > > Signed-off-by: Tyler Retzlaff > > --- > > lib/eal/include/generic/rte_atomic.h | 4 > > lib/eal/x

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-04 Thread Tyler Retzlaff
On Tue, Apr 04, 2023 at 09:53:21AM +0100, Bruce Richardson wrote: > On Mon, Apr 03, 2023 at 02:52:25PM -0700, Tyler Retzlaff wrote: > > Inline assembly is not supported for msvc x64 instead use > > _{Read,Write,ReadWrite}Barrier() intrinsics. > > > > Signed-off-by: Tyler Retzlaff > > --- > > lib

RE: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-04 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Tuesday, 4 April 2023 14.11 [...] > Another ore generic comment - do we really need to pollute all that code with > RTE_TOOLCHAIN_MSVC ifdefs? > Right now we have ability to have subdir per arch (x86/arm/etc.). > Can we tre

RE: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-04 Thread Konstantin Ananyev
> Inline assembly is not supported for msvc x64 instead use > _{Read,Write,ReadWrite}Barrier() intrinsics. > > Signed-off-by: Tyler Retzlaff > --- > lib/eal/include/generic/rte_atomic.h | 4 > lib/eal/x86/include/rte_atomic.h | 10 +- > 2 files changed, 13 insertions(+), 1 d

Re: [PATCH 3/9] eal: use barrier intrinsics when compiling with msvc

2023-04-04 Thread Bruce Richardson
On Mon, Apr 03, 2023 at 02:52:25PM -0700, Tyler Retzlaff wrote: > Inline assembly is not supported for msvc x64 instead use > _{Read,Write,ReadWrite}Barrier() intrinsics. > > Signed-off-by: Tyler Retzlaff > --- > lib/eal/include/generic/rte_atomic.h | 4 > lib/eal/x86/include/rte_atomic.h