> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Tuesday, 4 April 2023 14.11
[...] > Another ore generic comment - do we really need to pollute all that code with > RTE_TOOLCHAIN_MSVC ifdefs? > Right now we have ability to have subdir per arch (x86/arm/etc.). > Can we treat x86+windows+msvc as a special arch? I disagree with the per-arch suggestion. We should have arch directories in EAL only, where the differences are significant. Anything else, such as drivers and libraries, should be allowed to implement architecture and compiler specific variants using #ifdef or subdirectories/-files as the developer deems appropriate, i.e. #ifdef for few/minor variations, and subfiles or -directories for larger variations. Multi-architecture code is voluminous, but I don't want separate files for only small variations. It would be nice to agree on some official guidance on this for the coding guidelines.
