Re: [PATCH] lib: add get/set link settings interface

2024-07-22 Thread Ferruh Yigit
On 4/4/2024 12:38 AM, Stephen Hemminger wrote: > On Thu, 4 Apr 2024 00:08:41 +0200 > Marek Pazdan wrote: > >> I can remove this part (rte_eth_config), but the new API provides other >> link information which is not available from the existing API, like >> supported/advertising/partner_advertising

Re: [PATCH] lib: add get/set link settings interface

2024-04-05 Thread Dodji Seketeli
Hello, > On Fri, Apr 5, 2024 at 2:55 AM Tyler Retzlaff [...] >> i'm jealous we don't have libabigail on windows, so helpful. Heh, thank you for the kind words. David Marchand writes: [...] > libabigail is written in C++ and relies on the elfutils and libxml2 > libraries. That is correct.

Re: [PATCH] lib: add get/set link settings interface

2024-04-05 Thread David Marchand
On Fri, Apr 5, 2024 at 2:55 AM Tyler Retzlaff wrote: > On Thu, Apr 04, 2024 at 09:09:40AM +0200, David Marchand wrote: > > On Wed, Apr 3, 2024 at 6:49 PM Tyler Retzlaff > > > this breaks the abi. David does libabigail pick this up i wonder? > > > > Yes, the CI flagged it. > > > > Looking at the UN

Re: [PATCH] lib: add get/set link settings interface

2024-04-04 Thread Tyler Retzlaff
On Thu, Apr 04, 2024 at 05:55:18PM -0700, Tyler Retzlaff wrote: > On Thu, Apr 04, 2024 at 09:09:40AM +0200, David Marchand wrote: > > Hello Tyler, Marek, > > > > On Wed, Apr 3, 2024 at 6:49 PM Tyler Retzlaff > > wrote: > > > > > > On Wed, Apr 03, 2024 at 06:40:24AM -0700, Marek Pazdan wrote: > >

Re: [PATCH] lib: add get/set link settings interface

2024-04-04 Thread Tyler Retzlaff
On Thu, Apr 04, 2024 at 09:09:40AM +0200, David Marchand wrote: > Hello Tyler, Marek, > > On Wed, Apr 3, 2024 at 6:49 PM Tyler Retzlaff > wrote: > > > > On Wed, Apr 03, 2024 at 06:40:24AM -0700, Marek Pazdan wrote: > > > There are link settings parameters available from PMD drivers level > > >

Re: [PATCH] lib: add get/set link settings interface

2024-04-04 Thread Marek Pazdan
I can remove this part (rte_eth_config), but the new API provides other link information which is not available from the existing API, like supported/advertising/partner_advertising link modes. Additionally from what I see, rte_eth_confg is available from rte_eth_dev_conf_get API and it's copy of r

Re: [PATCH] lib: add get/set link settings interface

2024-04-04 Thread David Marchand
Hello Tyler, Marek, On Wed, Apr 3, 2024 at 6:49 PM Tyler Retzlaff wrote: > > On Wed, Apr 03, 2024 at 06:40:24AM -0700, Marek Pazdan wrote: > > There are link settings parameters available from PMD drivers level > > which are currently not exposed to the user via consistent interface. > > When

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Stephen Hemminger
On Thu, 4 Apr 2024 00:08:41 +0200 Marek Pazdan wrote: > I can remove this part (rte_eth_config), but the new API provides other > link information which is not available from the existing API, like > supported/advertising/partner_advertising link modes. > Additionally from what I see, rte_eth_con

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Stephen Hemminger
On Wed, 3 Apr 2024 16:59:08 +0200 Marek Pazdan wrote: > Hi Thomas, > > Information like advertising: speed, pause, autonegotiation etc. and that > same for link partner advertising. > I try to mimic ethtool since it's a common, well known and widely used tool > so adding an API which provides th

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Tyler Retzlaff
On Wed, Apr 03, 2024 at 06:40:24AM -0700, Marek Pazdan wrote: > There are link settings parameters available from PMD drivers level > which are currently not exposed to the user via consistent interface. > When interface is available for system level those information can > be acquired with 'et

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Thomas Monjalon
03/04/2024 16:59, Marek Pazdan: > Hi Thomas, > > Information like advertising: speed, pause, autonegotiation etc. and that > same for link partner advertising. speed and duplex are already provided in some existing API. > I try to mimic ethtool since it's a common, well known and widely used to

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Marek Pazdan
Hi Thomas, Information like advertising: speed, pause, autonegotiation etc. and that same for link partner advertising. I try to mimic ethtool since it's a common, well known and widely used tool so adding an API which provides the same set of information in case the interface is passthrough to dp

Re: [PATCH] lib: add get/set link settings interface

2024-04-03 Thread Thomas Monjalon
03/04/2024 15:59, Marek Pazdan: > There are link settings parameters available from PMD drivers level > which are currently not exposed to the user via consistent interface. > When interface is available for system level those information can > be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL