Re: [PATCH] ci: do not dump error logs in GHA containers

2022-04-29 Thread Aaron Conole
Honnappa Nagarahalli writes: > > >> >> On Tue, Apr 26, 2022 at 5:05 PM Aaron Conole >> wrote: >> > > >> > > TBH, I did not test Travis by lack of interest (plus I don't want to >> > > be bothered with their ui / credit stuff). >> > > We could consider dropping Travis in the near future. >> > >

RE: [PATCH] ci: do not dump error logs in GHA containers

2022-04-28 Thread Honnappa Nagarahalli
> > On Tue, Apr 26, 2022 at 5:05 PM Aaron Conole > wrote: > > > > > > TBH, I did not test Travis by lack of interest (plus I don't want to > > > be bothered with their ui / credit stuff). > > > We could consider dropping Travis in the near future. > > > > > > Opinions? > > > > I think it makes

Re: [PATCH] ci: do not dump error logs in GHA containers

2022-04-28 Thread David Marchand
On Tue, Apr 26, 2022 at 5:05 PM Aaron Conole wrote: > > > > TBH, I did not test Travis by lack of interest (plus I don't want to > > be bothered with their ui / credit stuff). > > We could consider dropping Travis in the near future. > > > > Opinions? > > I think it makes sense. We haven't had tr

Re: [PATCH] ci: do not dump error logs in GHA containers

2022-04-26 Thread Aaron Conole
David Marchand writes: > On Tue, Apr 26, 2022 at 9:09 AM David Marchand > wrote: >> >> On error, the build logs are displayed in GHA console and logs unless >> the GITHUB_WORKFLOW env variable is set. >> However, containers in GHA do not automatically inherit this variable. >> We could pass this

Re: [PATCH] ci: do not dump error logs in GHA containers

2022-04-26 Thread David Marchand
On Tue, Apr 26, 2022 at 9:09 AM David Marchand wrote: > > On error, the build logs are displayed in GHA console and logs unless > the GITHUB_WORKFLOW env variable is set. > However, containers in GHA do not automatically inherit this variable. > We could pass this variable in the container environ