Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-31 Thread Zhang, Xiao
> -Original Message- > From: Ori Kam > Sent: Tuesday, March 31, 2020 5:06 PM > To: Zhang, Xiao ; Zhao1, Wei ; > dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > > > > -Original Message- > > From: Zhang, Xiao

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-31 Thread Ori Kam
> -Original Message- > From: Zhang, Xiao > Subject: RE: app/testpmd: fix PPPOES flow API > > > > > -Original Message- > > From: Ori Kam > > Subject: RE: app/testpmd: fix PPPOES flow API > > > > > > > > > -Original Message- > > > From: Zhang, Xiao > > > > > > Hi Ori,

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-31 Thread Zhang, Xiao
> -Original Message- > From: Ori Kam > Sent: Tuesday, March 31, 2020 2:55 PM > To: Zhang, Xiao ; Zhao1, Wei ; > dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > > > > -Original Message- > > From: Zhang, Xiao

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-30 Thread Ori Kam
> -Original Message- > From: Zhang, Xiao > > Hi Ori, > > > -Original Message- > > From: Ori Kam > > > > Hi Xiao, > > > > > -Original Message- > > > From: Zhao1, Wei > > > > > > Hi, Ori > > > > > > > -Original Message- > > > > From: Ori Kam > > > > > > > > Hi

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-30 Thread Zhang, Xiao
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Monday, March 30, 2020 4:57 PM > To: Zhao1, Wei ; Zhang, Xiao ; > dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > Hi Xiao, > > > -Original Message- > > From

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-30 Thread Ori Kam
Hi Xiao, > -Original Message- > From: Zhao1, Wei > Sent: Monday, March 30, 2020 11:50 AM > To: Ori Kam ; Zhang, Xiao ; > dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > Hi, Ori > > > -Original Message- > > Fro

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-30 Thread Zhao1, Wei
Hi, Ori > -Original Message- > From: Ori Kam > Sent: Monday, March 30, 2020 3:43 PM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; Zhao1, Wei ; > sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > Hi Xiao > > > -Original Message- > > From:

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-30 Thread Ori Kam
Hi Xiao > -Original Message- > From: Zhang, Xiao > Sent: Monday, March 30, 2020 5:09 AM > To: Ori Kam ; dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; Zhao1, Wei ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > Hi Ori, > > > -Original Message- > > From: O

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-29 Thread Zhang, Xiao
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Sunday, March 29, 2020 8:46 PM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; Zhao1, Wei ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > Hi Xiao, > > > -Original Message- > > From:

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-29 Thread Ori Kam
Hi Xiao, > -Original Message- > From: Zhang, Xiao > Sent: Sunday, March 29, 2020 3:00 PM > To: Ori Kam ; dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; Zhao1, Wei ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > Hi Ori, > > > -Original Message- > > From:

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-29 Thread Zhang, Xiao
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Sunday, March 29, 2020 6:19 PM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; Zhao1, Wei ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > Hi Xiao, > > > -Original Message- > > From:

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-29 Thread Ori Kam
Hi Xiao, > -Original Message- > From: Zhang, Xiao > Sent: Sunday, March 29, 2020 12:06 PM > To: Ori Kam ; dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; Zhao1, Wei ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > Hi Ori, > > > -Original Message- > > From:

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-29 Thread Zhang, Xiao
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Sunday, March 29, 2020 2:28 PM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Wang, Ying A ; Zhang, Qi Z > ; Zhao1, Wei ; sta...@dpdk.org > Subject: RE: app/testpmd: fix PPPOES flow API > > Hi Xiao, > > Is the proto_id part of the basic heade

Re: [dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-28 Thread Ori Kam
Hi Xiao, Is the proto_id part of the basic header or not? >From the spec it looks like a different header. If it is part of the original header then all documentations and rte_structs should be changed, to reflect this. It will be very helpful if the patch message would explain the bug and why

[dpdk-dev] app/testpmd: fix PPPOES flow API

2020-03-27 Thread Xiao Zhang
The command line to create RTE flow for specific proto_id of PPPOES is not correct. This patch is to fix this issue. Fixes: 226c6e60c35b ("ethdev: add PPPoE to flow API") Cc: sta...@dpdk.org Signed-off-by: Xiao Zhang --- app/test-pmd/cmdline_flow.c | 13 +++-- 1 file changed, 3 insertio