Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload

2018-08-23 Thread Ferruh Yigit
njalon , "dev@dpdk.org" , >>> "Yigit, Ferruh" , "shah...@mellanox.com" >>> >>> Subject: RE: [dpdk-dev] [PATCH] examples: remove Rx checksum offload >>> >>> >>>> -Original Message- >>>>> Date:

Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload

2018-07-30 Thread Andrew Rybchenko
: [dpdk-dev] [PATCH] examples: remove Rx checksum offload -Original Message- Date: Mon, 30 Jul 2018 11:00:02 + From: "Ananyev, Konstantin" To: Thomas Monjalon , Jerin Jacob CC: "dev@dpdk.org" , "Yigit, Ferruh" , "shah...@mellanox.com" Subj

Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload

2018-07-30 Thread Jerin Jacob
-Original Message- > Date: Mon, 30 Jul 2018 14:12:12 + > From: "Ananyev, Konstantin" > To: Jerin Jacob > CC: Thomas Monjalon , "dev@dpdk.org" , > "Yigit, Ferruh" , "shah...@mellanox.com" > > Subject

Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload

2018-07-30 Thread Ananyev, Konstantin
> > -Original Message- > > Date: Mon, 30 Jul 2018 11:00:02 + > > From: "Ananyev, Konstantin" > > To: Thomas Monjalon , Jerin Jacob > > > > CC: "dev@dpdk.org" , "Yigit, Ferruh" > > , "shah...@mellanox.c

Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload

2018-07-30 Thread Jerin Jacob
-Original Message- > Date: Mon, 30 Jul 2018 11:00:02 + > From: "Ananyev, Konstantin" > To: Thomas Monjalon , Jerin Jacob > > CC: "dev@dpdk.org" , "Yigit, Ferruh" > , "shah...@mellanox.com" > Subject: RE: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload

2018-07-30 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 30, 2018 10:51 AM > To: Jerin Jacob ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Yigit, Ferruh ; shah...@mellanox.com > Subject: Re: [dpdk-dev] [PATCH] examples: remov

Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload

2018-07-30 Thread Thomas Monjalon
30/07/2018 11:35, Jerin Jacob: > From: "Ananyev, Konstantin" > > > > > > As of now, application does not check PKT_RX_*_CKSUM_* flags per > > > packet, so it does not matter DEV_RX_OFFLOAD_CHECKSUM enabled or not. > > > > > > Removing DEV_RX_OFFLOAD_CHECKSUM offload so that driver can save a few >

Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload

2018-07-30 Thread Shahaf Shuler
Monday, July 30, 2018 12:36 PM, Jerin Jacob: > > Subject: RE: [dpdk-dev] [PATCH] examples: remove Rx checksum offload > > > > > > Hi Jerin, > > Hi Konstantin, > > > > > > > > > As of now, application does not check PKT_R

Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload

2018-07-30 Thread Jerin Jacob
-Original Message- > Date: Mon, 30 Jul 2018 09:27:48 + > From: "Ananyev, Konstantin" > To: Jerin Jacob , "dev@dpdk.org" > > CC: "tho...@monjalon.net" , "Yigit, Ferruh" > , "shah...@mellanox.com" > Subject:

Re: [dpdk-dev] [PATCH] examples: remove Rx checksum offload

2018-07-30 Thread Ananyev, Konstantin
Hi Jerin, > > As of now, application does not check PKT_RX_*_CKSUM_* flags per > packet, so it does not matter DEV_RX_OFFLOAD_CHECKSUM enabled or not. > > Removing DEV_RX_OFFLOAD_CHECKSUM offload so that driver can save a few > cycles if possible. Personally, I'd move in other direction: keep R

[dpdk-dev] [PATCH] examples: remove Rx checksum offload

2018-07-29 Thread Jerin Jacob
As of now, application does not check PKT_RX_*_CKSUM_* flags per packet, so it does not matter DEV_RX_OFFLOAD_CHECKSUM enabled or not. Removing DEV_RX_OFFLOAD_CHECKSUM offload so that driver can save a few cycles if possible. Signed-off-by: Jerin Jacob --- examples/ip_fragmentation/main.c