30/07/2018 11:35, Jerin Jacob: > From: "Ananyev, Konstantin" <konstantin.anan...@intel.com> > > > > > > As of now, application does not check PKT_RX_*_CKSUM_* flags per > > > packet, so it does not matter DEV_RX_OFFLOAD_CHECKSUM enabled or not. > > > > > > Removing DEV_RX_OFFLOAD_CHECKSUM offload so that driver can save a few > > > cycles if possible. > > > > Personally, I'd move in other direction: keep RX checksum offload and add > > checks inside sample apps to handle (drop) packets with invalid checksum. > > OK. Till someones add the DROP logic in application, Can we take > this patch? Because there is no point in enabling DEV_RX_OFFLOAD_CHECKSUM > without DROP or any meaning full action in application.
If there is no patch sent to use this offload on August 1st, then I will apply this patch to remove the offload request.
