Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Slava Ovsiienko
nko > Sent: Thursday, October 15, 2020 16:07 > To: NBU-Contact-Thomas Monjalon ; Ferruh Yigit > ; Jerin Jacob ; Slava > Ovsiienko ; Andrew Rybchenko > > Cc: dpdk-dev ; Stephen Hemminger > ; Olivier Matz ; > Maxime Coquelin ; David Marchand > > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Slava Ovsiienko
Hi, Andrew > >> At least there are few simple limitations which are easy to > >> express: > >> 1. Maximum number of segments > > We have scatter capability and we do not report the maximal number of > > segments, it is on PMD own. We could add the field to the > > rte_eth_dev_info, but not sure w

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Slava Ovsiienko
xime Coquelin ; David Marchand > > Subject: Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split > > On 10/15/20 3:49 PM, Thomas Monjalon wrote: > > 15/10/2020 13:49, Slava Ovsiienko: > >> From: Ferruh Yigit > >>> On 10/15/2020 12:26 PM, Jerin Jacob wro

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Andrew Rybchenko
On 10/15/20 3:49 PM, Thomas Monjalon wrote: > 15/10/2020 13:49, Slava Ovsiienko: >> From: Ferruh Yigit >>> On 10/15/2020 12:26 PM, Jerin Jacob wrote: >>> >>> <...> >>> If we see some of the features of such kind or other PMDs adopts the split feature - we'll try to find the commo

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Thomas Monjalon
15/10/2020 13:49, Slava Ovsiienko: > From: Ferruh Yigit > > On 10/15/2020 12:26 PM, Jerin Jacob wrote: > > > > <...> > > > > > If we see some of the features of such kind or other PMDs adopts > > > the split feature - we'll try to find the common root and consider > > > the way how >

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Slava Ovsiienko
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 15, 2020 14:37 > To: Jerin Jacob ; Slava Ovsiienko > > Cc: dpdk-dev ; NBU-Contact-Thomas Monjalon > ; Stephen Hemminger > ; Olivier Matz ; > Maxime Coquelin ; David Marchand > ; Andrew Rybchenko > > Subject: Re: [PATCH v

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Ferruh Yigit
On 10/15/2020 12:26 PM, Jerin Jacob wrote: <...> If we see some of the features of such kind or other PMDs adopts the split feature - we'll try to find the common root and consider the way how to report it. My only concern with that approach will be ABI break again if something needs to expo

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Jerin Jacob
On Thu, Oct 15, 2020 at 4:21 PM Slava Ovsiienko wrote: > > Hi, Jerin > > > -Original Message- > > From: Jerin Jacob > > Sent: Thursday, October 15, 2020 13:28 > > To: Slava Ovsiienko > > Cc: dpdk-dev ; NBU-Contact-Thomas Monjalon > > ; Stephen Hemminger > > ; Ferruh Yigit ; > > Olivier M

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Andrew Rybchenko
n >> ; Stephen Hemminger >> ; Ferruh Yigit ; >> Olivier Matz ; Maxime Coquelin >> ; David Marchand >> ; Andrew Rybchenko >> >> Subject: Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split >> >> On 10/15/20 10:43 AM, Slava Ovsiienko wrote

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Slava Ovsiienko
Hi, Jerin > -Original Message- > From: Jerin Jacob > Sent: Thursday, October 15, 2020 13:28 > To: Slava Ovsiienko > Cc: dpdk-dev ; NBU-Contact-Thomas Monjalon > ; Stephen Hemminger > ; Ferruh Yigit ; > Olivier Matz ; Maxime Coquelin > ; David Marchand > ; Andrew Rybchenko > > Subject: R

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Slava Ovsiienko
t; ; David Marchand > ; Andrew Rybchenko > > Subject: Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split > > On 10/15/20 10:43 AM, Slava Ovsiienko wrote: > > Hi, Jerin > > > >> -Original Message- > >> From: Jerin Jacob > >>

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Jerin Jacob
On Thu, Oct 15, 2020 at 2:57 PM Jerin Jacob wrote: > > On Thu, Oct 15, 2020 at 1:13 PM Slava Ovsiienko > wrote: > > > > Hi, Jerin > > Hi Slava, > > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Wednesday, October 14, 2020 21:57 > > > To: Slava Ovsiienko > > > Cc: dpdk-

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Thomas Monjalon
15/10/2020 12:11, Andrew Rybchenko: > On 10/14/20 9:11 PM, Viacheslav Ovsiienko wrote: > > + /* Single pool configuration check. */ > > + if (rx_conf->rx_seg || rx_conf->rx_nseg) { > > Please, compare vs NULL and 0. IMHO, rx_nsegs check is sufficient. If it > is 0, nobody cares

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Andrew Rybchenko
On 10/14/20 9:11 PM, Viacheslav Ovsiienko wrote: > The DPDK datapath in the transmit direction is very flexible. > An application can build the multi-segment packet and manages > almost all data aspects - the memory pools where segments > are allocated from, the segment lengths, the memory attribut

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Andrew Rybchenko
On 10/15/20 10:43 AM, Slava Ovsiienko wrote: > Hi, Jerin > >> -Original Message- >> From: Jerin Jacob >> Sent: Wednesday, October 14, 2020 21:57 >> To: Slava Ovsiienko >> Cc: dpdk-dev ; NBU-Contact-Thomas Monjalon >> ; Stephen Hemminger >> ; Ferruh Yigit ; >> Olivier Matz ; Maxime Coquel

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Jerin Jacob
On Thu, Oct 15, 2020 at 1:13 PM Slava Ovsiienko wrote: > > Hi, Jerin Hi Slava, > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, October 14, 2020 21:57 > > To: Slava Ovsiienko > > Cc: dpdk-dev ; NBU-Contact-Thomas Monjalon > > ; Stephen Hemminger > > ; Ferruh Yigit ;

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-15 Thread Slava Ovsiienko
Hi, Jerin > -Original Message- > From: Jerin Jacob > Sent: Wednesday, October 14, 2020 21:57 > To: Slava Ovsiienko > Cc: dpdk-dev ; NBU-Contact-Thomas Monjalon > ; Stephen Hemminger > ; Ferruh Yigit ; > Olivier Matz ; Maxime Coquelin > ; David Marchand > ; Andrew Rybchenko > > Subject:

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-14 Thread Ajit Khaparde
On Wed, Oct 14, 2020 at 11:13 AM Viacheslav Ovsiienko wrote: > > The DPDK datapath in the transmit direction is very flexible. > An application can build the multi-segment packet and manages > almost all data aspects - the memory pools where segments > are allocated from, the segment lengths, the

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-14 Thread Thomas Monjalon
14/10/2020 20:11, Viacheslav Ovsiienko: > The DPDK datapath in the transmit direction is very flexible. > An application can build the multi-segment packet and manages > almost all data aspects - the memory pools where segments > are allocated from, the segment lengths, the memory attributes > like

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-14 Thread Jerin Jacob
On Wed, Oct 14, 2020 at 11:42 PM Viacheslav Ovsiienko wrote: > > The DPDK datapath in the transmit direction is very flexible. > An application can build the multi-segment packet and manages > almost all data aspects - the memory pools where segments > are allocated from, the segment lengths, the

[dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split

2020-10-14 Thread Viacheslav Ovsiienko
The DPDK datapath in the transmit direction is very flexible. An application can build the multi-segment packet and manages almost all data aspects - the memory pools where segments are allocated from, the segment lengths, the memory attributes like external buffers, registered for DMA, etc. In th