Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD

2018-01-11 Thread Ferruh Yigit
On 1/11/2018 2:07 AM, Lu, Wenzhuo wrote: > Hi Stephen, > >> -Original Message- >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Thursday, January 11, 2018 1:15 AM >> To: Lu, Wenzhuo >> Cc: dev@dpdk.org; Wu, Jingjing >> Su

Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD

2018-01-10 Thread Lu, Wenzhuo
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, January 11, 2018 1:18 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD &

Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD

2018-01-10 Thread Lu, Wenzhuo
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, January 11, 2018 1:15 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD &

Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD

2018-01-10 Thread Stephen Hemminger
On Wed, 10 Jan 2018 14:15:49 +0800 Wenzhuo Lu wrote: > +/* spinlock func for base code */ > +void > +avf_init_spinlock_d(struct avf_spinlock *sp) > +{ > + rte_spinlock_init(&sp->spinlock); > +} > + > +void > +avf_acquire_spinlock_d(struct avf_spinlock *sp) > +{ > + rte_spinlock_lock(&sp->

Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD

2018-01-10 Thread Stephen Hemminger
On Wed, 10 Jan 2018 14:15:49 +0800 Wenzhuo Lu wrote: > + > +#define AVF_MAX_NUM_QUEUES 16 > +/* Vlan table size */ > +#define AVF_VLAN_TB_SIZE (4096 / (CHAR_BIT * sizeof(uint32_t))) You could use ETHER_MAX_VLAN_ID (which is 4095). Also it is most efficient if bit tables use u

[dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD

2018-01-09 Thread Wenzhuo Lu
From: Jingjing Wu Signed-off-by: Jingjing Wu --- config/common_base | 5 + drivers/net/Makefile| 1 + drivers/net/avf/Makefile| 47 drivers/net/avf/avf.h | 187 ++ drivers/net/avf/avf_ethdev.c