Re: [dpdk-dev] [PATCH v5 6/6] ethdev: complete closing of port

2018-10-18 Thread Thomas Monjalon
18/10/2018 10:33, Andrew Rybchenko: > On 10/18/18 4:24 AM, Thomas Monjalon wrote: > > After closing a port, it cannot be restarted. > > So there is no reason to not free all associated resources. > > > > The last step was done with rte_eth_dev_detach() which is deprecated. > > Instead of blindly re

Re: [dpdk-dev] [PATCH v5 6/6] ethdev: complete closing of port

2018-10-18 Thread Andrew Rybchenko
On 10/18/18 4:24 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should che

[dpdk-dev] [PATCH v5 6/6] ethdev: complete closing of port

2018-10-17 Thread Thomas Monjalon
After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should check if no more port (ethdev, cryptodev, etc) is