On 10/18/18 4:24 AM, Thomas Monjalon wrote:
After closing a port, it cannot be restarted.
So there is no reason to not free all associated resources.
The last step was done with rte_eth_dev_detach() which is deprecated.
Instead of blindly removing the associated rte_device, the driver should
check if no more port (ethdev, cryptodev, etc) is open for the device.
The last ethdev freeing which were done by rte_eth_dev_detach(),
are now done at the end of rte_eth_dev_close().
Some drivers does not allocate MAC addresses dynamically or separately.
In those cases, the pointer is set to NULL, in order to avoid wrongly
freeing them in rte_eth_dev_release_port().
A closed port will have the state RTE_ETH_DEV_UNUSED which is
considered as invalid by rte_eth_dev_is_valid_port().
So validity is not checked anymore for closed ports in testpmd.
If the driver is trying to free the port again, the function
rte_eth_dev_release_port() will abort with -ENODEV error.
Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
I've tested the patch series together with [1].
As I expected it makes problems and resource leaks if
rte_eth_dev_close() is used.
Everything is OK if I do port stop and detach (with net/sfc
patch which does close from uninit).
If I do port stop, close and detach, the last one returns
error since the device already released and net/sfc uninit
is never called.
Basically it should be one function which is called in both
cases: dev_close or pci_device remove. Similar changes
should be done in many PCI drivers.
If I drop the patch, everything seems to be work fine
from the first sight.
May be it should be removed from the patchset and
considered separately.
[1] http://patches.dpdk.org/project/dpdk/list/?series=1966
