Re: [dpdk-dev] [PATCH v5 20/20] ethdev: Decouple from PCI device

2016-12-23 Thread Jan Blunck
On Fri, Dec 23, 2016 at 5:17 PM, Thomas Monjalon wrote: > 2016-12-23 16:58, Jan Blunck: >> +/** >> + * @internal >> + * Helper macro for drivers that need to convert to struct rte_pci_device. >> + */ >> +#define RTE_DEV_PCI_DEV(ptr) container_of(ptr, struct rte_pci_device, >> device) > > Do you p

Re: [dpdk-dev] [PATCH v5 20/20] ethdev: Decouple from PCI device

2016-12-23 Thread Thomas Monjalon
2016-12-23 16:58, Jan Blunck: > +/** > + * @internal > + * Helper macro for drivers that need to convert to struct rte_pci_device. > + */ > +#define RTE_DEV_PCI_DEV(ptr) container_of(ptr, struct rte_pci_device, device) Do you prefer to rename to RTE_DEV_TO_PCI? > + struct rte_device *device

[dpdk-dev] [PATCH v5 20/20] ethdev: Decouple from PCI device

2016-12-23 Thread Jan Blunck
This makes struct rte_eth_dev independent of struct rte_pci_device by replacing it with a pointer to the generic struct rte_device. Signed-off-by: Jan Blunck Acked-by: Shreyansh Jain --- app/test/virtual_pmd.c | 4 ++-- drivers/net/bnx2x/bnx2x_ethdev.c| 4 ++-- driver