Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-11 Thread Ray Kinsella
na.tr...@intel.com; ray.kinse...@intel.com; bruce.richard...@intel.com >> Subject: Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get >> function >> >> Hi Akhil, >> >> So 1st thing is that this that validate-abi uses "ABI Compliance Check

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-11 Thread Akhil Goyal
1, 2020 1:48 PM > To: 'Ray Kinsella' ; Arek Kusztal > ; dev@dpdk.org > Cc: fiona.tr...@intel.com; ray.kinse...@intel.com; bruce.richard...@intel.com > Subject: RE: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get > function > > Hi Ray, > > Previ

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-11 Thread Akhil Goyal
> Cc: fiona.tr...@intel.com; ray.kinse...@intel.com; bruce.richard...@intel.com > Subject: Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get > function > > Hi Akhil, > > So 1st thing is that this that validate-abi uses "ABI Compliance Checker", > which doe

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-11 Thread Ray Kinsella
Hi Akhil, So 1st thing is that this that validate-abi uses "ABI Compliance Checker", which does not use libabigail.ignore. So you will end up with different results compared to using libabigail as follows: DPDK_ABI_REF_DIR= DPDK_ABI_REF_VERSION=v20.02 ./devtools/test-meson-builds.sh I did che

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-10 Thread Ray Kinsella
Hi Akhil, I didn't see this - checking again. Ray K On 09/05/2020 22:11, Akhil Goyal wrote: > Hi Ray/Arek, > > I still see Incompatible cryptodev even after update in the abignore list. > I checked it with ./devtools/validate-abi.sh > NOTICE: ABI may be incompatible, check reports/logs for deta

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-09 Thread Akhil Goyal
Hi Ray/Arek, I still see Incompatible cryptodev even after update in the abignore list. I checked it with ./devtools/validate-abi.sh NOTICE: ABI may be incompatible, check reports/logs for details. NOTICE: Incompatible list: librte_cryptodev.so Did I miss something? > > On 07/05/2020 11:57, A

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-07 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, May 7, 2020 11:57 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; Kinsella, Ray > ; > akhil.go...@nxp.com; Richardson, Bruce ; Kusztal, > ArkadiuszX > > Subject: [PATCH v5 2/2] cryptodev: version cryptodev info get functio

Re: [dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-07 Thread Ray Kinsella
On 07/05/2020 11:57, Arek Kusztal wrote: > This patch adds versioned function rte_cryptodev_info_get() > to prevent some issues with ABI policy. > Node v21 works in same way as before, returning driver capabilities > directly to the API caller. These capabilities may include new elements > not p

[dpdk-dev] [PATCH v5 2/2] cryptodev: version cryptodev info get function

2020-05-07 Thread Arek Kusztal
This patch adds versioned function rte_cryptodev_info_get() to prevent some issues with ABI policy. Node v21 works in same way as before, returning driver capabilities directly to the API caller. These capabilities may include new elements not part of the v20 ABI. Node v20 function maintains compat