Hi Akhil, I didn't see this - checking again.
Ray K On 09/05/2020 22:11, Akhil Goyal wrote: > Hi Ray/Arek, > > I still see Incompatible cryptodev even after update in the abignore list. > I checked it with ./devtools/validate-abi.sh > NOTICE: ABI may be incompatible, check reports/logs for details. > NOTICE: Incompatible list: librte_cryptodev.so > > Did I miss something? > > >> >> On 07/05/2020 11:57, Arek Kusztal wrote: >>> This patch adds versioned function rte_cryptodev_info_get() >>> to prevent some issues with ABI policy. >>> Node v21 works in same way as before, returning driver capabilities >>> directly to the API caller. These capabilities may include new elements >>> not part of the v20 ABI. >>> Node v20 function maintains compatibility with v20 ABI releases >>> by stripping out elements not supported in v20 ABI. Because >>> rte_cryptodev_info_get is called by other API functions, >>> rte_cryptodev_sym_capability_get function is versioned the same way. >>> >>> Signed-off-by: Arek Kusztal <arkadiuszx.kusz...@intel.com> >>> --- >>> v2: >>> - changed version numbers of symbols to 20.0.2 >>> v3: >>> - added v2/v3 informations >>> - changed version numbers of symbols to 21 >>> v4: >>> - fixed clang build by movind binding default symbol >>> - implemented mailing list comments >>> - added abidiff tool suppression entries >>> v5: >>> - fixed meson build >>> >>> devtools/libabigail.abignore | 8 ++ >>> lib/librte_cryptodev/meson.build | 1 + >>> lib/librte_cryptodev/rte_cryptodev.c | 147 >> ++++++++++++++++++++++++- >>> lib/librte_cryptodev/rte_cryptodev.h | 34 +++++- >>> lib/librte_cryptodev/rte_cryptodev_version.map | 7 ++ >>> 5 files changed, 191 insertions(+), 6 deletions(-) >>> >> [SNIP] >> >> Acked-by: Ray Kinsella <m...@ashroe.eu>
