Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs

2020-10-15 Thread Bing Zhao
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, October 15, 2020 6:34 PM > To: Bing Zhao > Cc: Ori Kam ; ferruh.yi...@intel.com; > arybche...@solarflare.com; m...@ashroe.eu; nhor...@tuxdriver.com; > bernard.iremon...@intel.com; beilei.x...@intel.com; > wenzhuo..

Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs

2020-10-15 Thread Thomas Monjalon
15/10/2020 07:35, Bing Zhao: > v5: > * Change EINVAL to ENODEV > * add newline character in the end of log line > * descriptions update It looks good. More minor coding style comments below. With those, Acked-by: Thomas Monjalon > + if (ret) Coding style recommends explicit comparison

[dpdk-dev] [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs

2020-10-14 Thread Bing Zhao
In single port hairpin mode, all the hairpin TX and RX queues belong to the same device. After the queues are set up properly, there is no other dependency between the TX queue and its RX peer queue. The binding process that connected the TX and RX queues together from hardware level will be done a