Hi Thomas, > -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Thursday, October 15, 2020 6:34 PM > To: Bing Zhao <bi...@nvidia.com> > Cc: Ori Kam <or...@nvidia.com>; ferruh.yi...@intel.com; > arybche...@solarflare.com; m...@ashroe.eu; nhor...@tuxdriver.com; > bernard.iremon...@intel.com; beilei.x...@intel.com; > wenzhuo...@intel.com; dev@dpdk.org > Subject: Re: [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs > > External email: Use caution opening links or attachments > > > 15/10/2020 07:35, Bing Zhao: > > v5: > > * Change EINVAL to ENODEV > > * add newline character in the end of log line > > * descriptions update > > It looks good. > More minor coding style comments below. With those, > Acked-by: Thomas Monjalon <tho...@monjalon.net>
Thanks for the review and comments > > > + if (ret) > > Coding style recommends explicit comparison with == or != Done > > > + RTE_ETHDEV_LOG(ERR, "Failed to bind hairpin TX %d " > > + "to RX %d (%d - all ports)\n", > tx_port, > > + rx_port, RTE_MAX_ETHPORTS); > > It is preferred not splitting the log lines, or maybe only after a > format specifier, so it can be grepped. > Here the space after %d would be better on the next line. > > In general Rx/Tx is preferred over the full capital RX/TX version. Done > > Thanks > BR. Bing
