Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-17 Thread Thomas Monjalon
17/04/2019 15:39, Ananyev, Konstantin: > In general, I still think that sync primitives better to stay inlined - there > is no much point to create ones > and then figure out that no-one using them because they are too slow. > Though if there is no real perf difference between inlined and normal -

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-17 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > > > > > > > > > > > > > After evaluating long term API/ABI issues, I > > > > > > > > > > > > > think you need to get rid of almost all use of > > > > > > > > > > > > > inline and visible structures. Yes it might be > > > > > > > > > > > > > marginally slower, but you tha

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-17 Thread Ananyev, Konstantin
> > > > > > > > > > > > > > > > > > > > > > > > After evaluating long term API/ABI issues, I think > > > > > > > > > > > > you need to get rid of almost all use of inline and > > > > > > > > > > > > visible structures. Yes it might be marginally > > > > > > > > > > > > slower, but you thank me >

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-16 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > > > > > > > > > After evaluating long term API/ABI issues, I think > > > > > > > > > > > you need to get rid of almost all use of inline and > > > > > > > > > > > visible structures. Yes it might be marginally > > > > > > > > > > > slower, but you thank me > > > > > the

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-16 Thread Stephen Hemminger
On Tue, 16 Apr 2019 16:56:32 + Honnappa Nagarahalli wrote: > > > > > > > > > > > > On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Add RCU library supporting quiescent state based > > > > > > > > > > > memory r

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-16 Thread Honnappa Nagarahalli
> > > > > > > > > > On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Add RCU library supporting quiescent state based > > > > > > > > > > memory reclamation > > > > > > > > > method. > > > > > > > > > > This library helps ident

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-16 Thread Stephen Hemminger
On Tue, 16 Apr 2019 05:29:21 + Honnappa Nagarahalli wrote: > > > > > > > > On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Add RCU library supporting quiescent state based memory > > > > > > > > > reclamation > > > > > > >

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Honnappa Nagarahalli
> > > > > > > On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli > > > > > > > wrote: > > > > > > > > > > > > > > > Add RCU library supporting quiescent state based memory > > > > > > > > reclamation > > > > > > > method. > > > > > > > > This library helps identify the quiescent state of the

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Stephen Hemminger
On Mon, 15 Apr 2019 17:39:07 + "Ananyev, Konstantin" wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, April 15, 2019 4:39 PM > > To: Ananyev, Konstantin > > Cc: Honnappa Nagarahalli ; > > paul...@linux.ibm.com; Kovacevic

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Honnappa Nagarahalli
> > > > > > > > > > > > After evaluating long term API/ABI issues, I think you need to > > > > > > get rid of almost all use of inline and visible structures. > > > > > > Yes it might be marginally slower, but you thank me the first time > you have to fix something. > > > > > > > > > > > Agree, I w

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Ananyev, Konstantin
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, April 15, 2019 4:39 PM > To: Ananyev, Konstantin > Cc: Honnappa Nagarahalli ; > paul...@linux.ibm.com; Kovacevic, Marko > ; dev@dpdk.org; Gavin Hu (Arm Technology China) > ; Dharmik Thak

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Stephen Hemminger
On Mon, 15 Apr 2019 12:24:47 + "Ananyev, Konstantin" wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Saturday, April 13, 2019 12:06 AM > > To: Honnappa Nagarahalli > > Cc: Ananyev, Konstantin ; > > paul...@linux.ibm.com; Kovace

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-15 Thread Ananyev, Konstantin
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, April 13, 2019 12:06 AM > To: Honnappa Nagarahalli > Cc: Ananyev, Konstantin ; > paul...@linux.ibm.com; Kovacevic, Marko ; > dev@dpdk.org; Gavin Hu (Arm Technology China) ; Dharmik > T

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Stephen Hemminger
On Fri, 12 Apr 2019 22:24:45 + Honnappa Nagarahalli wrote: > > > > On Fri, 12 Apr 2019 15:20:37 -0500 > > Honnappa Nagarahalli wrote: > > > > > Add RCU library supporting quiescent state based memory reclamation > > method. > > > This library helps identify the quiescent state of the

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Honnappa Nagarahalli
> > On Fri, 12 Apr 2019 15:20:37 -0500 > Honnappa Nagarahalli wrote: > > > Add RCU library supporting quiescent state based memory reclamation > method. > > This library helps identify the quiescent state of the reader threads > > so that the writers can free the memory associated with the lock

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Stephen Hemminger
On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli wrote: > Add RCU library supporting quiescent state based memory reclamation method. > This library helps identify the quiescent state of the reader threads so > that the writers can free the memory associated with the lock less data > struc

[dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Honnappa Nagarahalli
Add RCU library supporting quiescent state based memory reclamation method. This library helps identify the quiescent state of the reader threads so that the writers can free the memory associated with the lock less data structures. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Steve Capper R