Re: [dpdk-dev] [PATCH v5 07/14] ring: make bulk and burst fn return vals consistent

2017-04-13 Thread Bruce Richardson
On Thu, Apr 13, 2017 at 07:42:39AM +0100, Wang, Zhihong wrote: > Hi Bruce, > > This patch changes the behavior and causes some existing code to > malfunction, e.g. bond_ethdev_stop() will get stuck here: > > while (rte_ring_dequeue(port->rx_ring, &pkt) != -ENOENT) > rte_pktmbuf_free

Re: [dpdk-dev] [PATCH v5 07/14] ring: make bulk and burst fn return vals consistent

2017-04-12 Thread Wang, Zhihong
ev_stop(). Thanks Zhihong > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, March 29, 2017 9:10 PM > To: olivier.m...@6wind.com > Cc: dev@dpdk.org; Richardson, Bruce > Subject: [dpdk-dev] [PATCH v5 07/14] rin

[dpdk-dev] [PATCH v5 07/14] ring: make bulk and burst fn return vals consistent

2017-03-29 Thread Bruce Richardson
The bulk fns for rings returns 0 for all elements enqueued and negative for no space. Change that to make them consistent with the burst functions in returning the number of elements enqueued/dequeued, i.e. 0 or N. This change also allows the return value from enq/deq to be used directly without a