Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2021-01-21 Thread 谢华伟(此时此刻）
On 2021/1/21 16:47, Maxime Coquelin wrote: On 1/21/21 5:12 AM, 谢华伟(此时此刻） wrote: On 2021/1/13 1:37, Maxime Coquelin wrote: On 10/22/20 5:51 PM, 谢华伟(此时此刻） wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2021-01-21 Thread Maxime Coquelin
On 1/21/21 5:12 AM, 谢华伟(此时此刻） wrote: > > On 2021/1/13 1:37, Maxime Coquelin wrote: >> >> On 10/22/20 5:51 PM, 谢华伟(此时此刻） wrote: >>> From: "huawei.xhw" >>> >>> Legacy virtio-pci only supports PIO BAR resource. As we need to >>> create lots of >>> virtio devices and PIO resource on x86 is very li

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2021-01-20 Thread 谢华伟(此时此刻）
On 2021/1/13 1:37, Maxime Coquelin wrote: On 10/22/20 5:51 PM, 谢华伟(此时此刻） wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO and MMIO B

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2021-01-14 Thread 谢华伟(此时此刻）
On 2021/1/13 1:37, Maxime Coquelin wrote: On 10/22/20 5:51 PM, 谢华伟(此时此刻） wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO and MMIO B

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2021-01-12 Thread Maxime Coquelin
On 10/22/20 5:51 PM, 谢华伟(此时此刻） wrote: > From: "huawei.xhw" > > Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of > virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. > > Kernel supports both PIO and MMIO BAR for legacy virtio-pci device.

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-12-15 Thread Maxime Coquelin
Hi Huawei, On 12/14/20 3:24 PM, 谢华伟(此时此刻） wrote: > Hi Maxime and David: > > Could we start to review this patch? Yes, I plan to work on it after the holidays, let's target -rc1. Thanks, Maxime > /Thanks, huawei > > > On 2020/11/10 20:42, David Marchand wrote: >> On Tue, Nov 10, 2020 at 1:35

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-12-14 Thread 谢华伟(此时此刻）
Hi Maxime and David: Could we start to review this patch? /Thanks, huawei On 2020/11/10 20:42, David Marchand wrote: On Tue, Nov 10, 2020 at 1:35 PM 谢华伟(此时此刻） wrote: Previously there are different ways to get port address based on different DPDK uio driver(IGB_UIO/UIO_PCI_GENERIC/VFIO), whi

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-11-12 Thread 谢华伟(此时此刻）
On 2020/11/10 20:42, David Marchand wrote: On Tue, Nov 10, 2020 at 1:35 PM 谢华伟(此时此刻） wrote: Previously there are different ways to get port address based on different DPDK uio driver(IGB_UIO/UIO_PCI_GENERIC/VFIO), which is actually not necessary. This patch makes IO/MMIO port map/RW API more

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-11-10 Thread David Marchand
On Tue, Nov 10, 2020 at 1:35 PM 谢华伟(此时此刻） wrote: > Previously there are different ways to get port address based on > different DPDK uio driver(IGB_UIO/UIO_PCI_GENERIC/VFIO), which is > actually not necessary. > > This patch makes IO/MMIO port map/RW API more generic, which also > supports MMIO.

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-11-10 Thread 谢华伟(此时此刻）
Hi David: I see that you are assigned the reviewer of this patch, and Ferruh have helped reviewed it. I rebased this patch based on his comments. Previously there are different ways to get port address based on different DPDK uio driver(IGB_UIO/UIO_PCI_GENERIC/VFIO), which is actually not ne

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-11-02 Thread 谢华伟(此时此刻）
Hi Ferruh: Comments to this v5 version? On 2020/10/22 23:51, 谢华伟(此时此刻） wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO and MMIO BAR f

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-10-27 Thread 谢华伟(此时此刻）
On 2020/10/27 16:50, chris wrote: @Ferruh: this patch is tested with both PIO and MMIO bar using testpmd and start tx_first. vfio/igb_uio tested with MMIO bar (uio_pci_generic doesn't work with msix, so it isn't tested) uio_pci_generic tested with PIO bar (igb_uio has unknown symbols, not

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-10-27 Thread 谢华伟(此时此刻）
@Ferruh: this patch is tested with both PIO and MMIO bar using testpmd and start tx_first. vfio/igb_uio tested with MMIO bar (uio_pci_generic doesn't work with msix, so it isn't tested) uio_pci_generic tested with PIO bar (igb_uio has unknown symbols, not tested). Weird igb_uio doens't hav

[dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-10-22 Thread 谢华伟(此时此刻）
From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device. We handles different type of BAR in the similar way.